Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_errors.py #537

Open
Jasha10 opened this issue Feb 11, 2021 · 3 comments
Open

Refactor test_errors.py #537

Jasha10 opened this issue Feb 11, 2021 · 3 comments

Comments

@Jasha10
Copy link
Collaborator

Jasha10 commented Feb 11, 2021

test_errors should probably be reorganized and broken into smaller functions (while reusing the error validation logic).

Originally posted by @omry in #503 (comment)

@Jasha10 Jasha10 self-assigned this Feb 11, 2021
@omry
Copy link
Owner

omry commented Feb 11, 2021

Please wait with this until we merge #445.

@Jasha10 Jasha10 removed their assignment May 21, 2021
@Jasha10
Copy link
Collaborator Author

Jasha10 commented Jun 8, 2021

What would be a good first step?
Break the list of test cases into several smaller lists?

@omry
Copy link
Owner

omry commented Jun 8, 2021

Yeah, potentially calling a common function from various topic specific files.

Keep in mind that for now we have a 2.1 release branch and bug fixes in master are still likely to be ported to that branch. for that reason I think we should wait a while and only do this after Hydra 1.1 is released and had some time to stabilize (otherwise we will need to port the refactoring to the 2.1_branch to avoid conflicts when we cherry-pick other fixes to it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants