Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error merging into Optional[List[int]] = None #428

Closed
omry opened this issue Nov 3, 2020 · 2 comments
Closed

Error merging into Optional[List[int]] = None #428

omry opened this issue Nov 3, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@omry
Copy link
Owner

omry commented Nov 3, 2020

repro:

from dataclasses import dataclass
from typing import Optional, List
from omegaconf import OmegaConf


@dataclass
class Config:
    my_field: Optional[List[int]] = None


OmegaConf.merge(Config, Config)

This is a bug in 2.0 and also in master (and should be fixed in both).

@omry
Copy link
Owner Author

omry commented Nov 3, 2020

Fixed in 19da4a4 for 2.0.
2.0.4 coming.

@omry
Copy link
Owner Author

omry commented Nov 4, 2020

#430 fixes in master.
Released 2.1.0-dev10 with this fix.

@omry omry closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant