Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect interpolation bug #283

Closed
omry opened this issue Jul 6, 2020 · 2 comments · Fixed by #346
Closed

Indirect interpolation bug #283

omry opened this issue Jul 6, 2020 · 2 comments · Fixed by #346
Labels
bug Something isn't working difficult

Comments

@omry
Copy link
Owner

omry commented Jul 6, 2020

Minimal example:

transform:
  standard_transforms:
    pre_transforms:
    - transform: NormalizeScale
model:
  transforms: ${transform.standard_transforms}
dataset:
  pre_transforms: ${model.transforms.pre_transforms}

to trigger convert to container with OmegaConf.to_container().

@omry omry added the bug Something isn't working label Jul 6, 2020
@omry omry added this to the OmegaConf 2.0.1 milestone Jul 6, 2020
@omry omry added the difficult label Jul 11, 2020
@omry
Copy link
Owner Author

omry commented Jul 17, 2020

@odelalleau, can you check if your nested interpolation fix is accidentally solving this bug? :)
I think not but worth a shot.

@odelalleau
Copy link
Collaborator

@omry it doesn't (the code path is unchanged for "simple" interpolations involving a single ${..})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficult
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants