Make GitExtensions project authority of GIT info

Prevents environment data from getting stale by a commit but GitGUI not being rebuilt

Author: vbjay

GitExtensions/GitExtensions.csproj

@@ -87,6 +87,13 @@
   <ItemGroup>
     <EmbeddedResource Include="AutoCompleteRegexes.txt" />
   </ItemGroup>
+  <ItemGroup>
+    <PackageReference Include="GitInfo">
+      <Version>2.0.18</Version>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Target Name="AddPluginBinaries" AfterTargets="ResolveProjectReferences">
     <ItemGroup>

GitExtensions/Program.cs

@@ -54,6 +54,9 @@ private static void Main()
                 }
             }
 
+            // This is done here so these values can be used in the GitGui project but this project is the authority of the values.
+            UserEnvironmentInformation.Initialise(ThisAssembly.Git.Sha, ThisAssembly.Git.IsDirty);
+
             // NOTE we perform the rest of the application's startup in another method to defer
             // the JIT processing more types than required to configure NBug.
             // In this way, there's more chance we can handle startup exceptions correctly.

GitUI/GitUI.csproj

@@ -58,11 +58,6 @@
     <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="GitInfo">
-      <Version>2.0.18</Version>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
     <PackageReference Include="Microsoft-WindowsAPICodePack-Core">
       <Version>1.1.3.3</Version>
     </PackageReference>

GitUI/UserEnvironmentInformation.cs

@@ -8,13 +8,19 @@ namespace GitUI
 {
     public sealed class UserEnvironmentInformation
     {
-        public static void CopyInformation()
-        {
-            Clipboard.SetText(GetInformation());
-        }
+        private static bool _alreadySet;
+        private static bool _dirty;
+        private static string _sha;
+
+        public static void CopyInformation() => Clipboard.SetText(GetInformation());
 
         public static string GetInformation()
         {
+            if (!_alreadySet)
+            {
+                throw new InvalidOperationException($"{nameof(Initialise)} must be called first");
+            }
+
             string gitVer;
             try
             {
@@ -27,12 +33,24 @@ public static string GetInformation()
 
             StringBuilder sb = new StringBuilder();
 
-            sb.AppendFormat("- Git Extensions {0}{1}", AppSettings.ProductVersion, Environment.NewLine);
-            sb.AppendFormat("- {0} {1}{2}", ThisAssembly.Git.Sha, ThisAssembly.Git.IsDirty ? " (Dirty)" : "", Environment.NewLine);
-            sb.AppendFormat("- Git {0}{1}", gitVer, Environment.NewLine);
-            sb.AppendFormat("- {0}{1}", Environment.OSVersion, Environment.NewLine);
-            sb.AppendFormat("- {0}", RuntimeInformation.FrameworkDescription);
+            sb.Append($"- Git Extensions {AppSettings.ProductVersion}{Environment.NewLine}");
+            sb.Append($"- {_sha} {(_dirty ? " (Dirty)" : "")}{Environment.NewLine}");
+            sb.Append($"- Git {gitVer}{Environment.NewLine}");
+            sb.Append($"- {Environment.OSVersion}{Environment.NewLine}");
+            sb.Append($"- {RuntimeInformation.FrameworkDescription}");
             return sb.ToString();
         }
+
+        public static void Initialise(string sha, bool isDirty)
+        {
+            if (_alreadySet)
+            {
+                return;
+            }
+
+            _alreadySet = true;
+            _sha = sha;
+            _dirty = isDirty;
+        }
     }
 }

UnitTests/GitUITests/TranslationTest.cs

@@ -28,6 +28,7 @@ public void TearDown()
         [Apartment(ApartmentState.STA)]
         public void CreateInstanceOfClass()
         {
+            UserEnvironmentInformation.Initialise("", false);
             var translatableTypes = TranslationUtil.GetTranslatableTypes();
 
             var problems = new List<(string typeName, Exception exception)>();