Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

fix: use showCommandHelp to delegate topic help #58

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Conversation

RasPhilCo
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #58 into master will decrease coverage by 6.63%.
The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   69.93%   63.29%   -6.64%     
==========================================
  Files           4        5       +1     
  Lines         143      158      +15     
  Branches       29       35       +6     
==========================================
  Hits          100      100              
- Misses         27       39      +12     
- Partials       16       19       +3
Impacted Files Coverage Δ
src/util.ts 38.88% <37.5%> (ø)
src/command.ts 76.25% <87.5%> (+1.58%) ⬆️
src/index.ts 35.71% <0%> (-41.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7de62...69b5a2c. Read the comment docs.

@@ -241,6 +241,7 @@ USAGE

OPTIONS
--help show CLI help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdxcode single-cli help didn't have a trailing newline

Copy link
Contributor

@jdx jdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good solution other than the imports which I think can be easily addressed

@RasPhilCo RasPhilCo merged commit 3c0bafd into master Apr 15, 2019
@RasPhilCo RasPhilCo deleted the help-topics branch April 15, 2019 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants