-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tree-sitter #305
Comments
We have. IMHO, it probably would be a good idea. Someone will have to step in an do it though — I do not have the time for that. |
Seems someone created an Or we can ask the author to merge his mode with Tuareg, as it seems he hasn't implemented indentation using treesitter and uses Tuareg for it. /cc @orbitz Given the small size of our community, probably fewer major modes are better for everyone. |
I'd welcome support for treesitter, indeed, and generally consolidating modes rather than having yet more of them (it's bad enough that we have |
If any existing tuareg-mode contributors are interested in adding treesitter support, my employer would be interested in funding that work. Since we have a number of extensions to OCaml syntax which often break tuareg-mode's syntax highlighting, it would make our life easier if tuareg-mode used a tree-sitter grammar (which, since it's useful for more than just Emacs syntax highlighting, is more likely to be kept up to date). So if anyone's interested (or knows someone who might be interested), you can email me at [email protected] (sorry if this comment is inappropriate here) (We've also been considering making a new treesitter-based mode from scratch simply because it would be easier, and has the potential to go into core Emacs which might be nice. But improving tuareg-mode would probably be better) |
I've started to experiment with a TreeSitter-powered OCaml mode here https://github.com/bbatsov/neocaml Let's see how far I'll be able to get. For now I prefer to work in a fresh project, just because it's much easier to play with TS this way, but if I get to a meaningful place I'd be happy to adapt the TS features for Tuareg. My initial impressions are that getting font-lock support and structured navigation is fairly easy, but I'm guessing the indentation part will be trickier given OCaml's syntax. I'm hoping I'll be able to adapt Tuareg's SMIE approach to TS somehow. |
Has anyone given thought to using tree-sitting in tuareg? (Or writing a new mode from scratch with tree-sitter and taking this opportunity to do some compatibility-breaking fixes on tuareg?)
The text was updated successfully, but these errors were encountered: