Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample times double call #81

Open
tylerbarna opened this issue Apr 26, 2023 · 0 comments · May be fixed by #82
Open

sample times double call #81

tylerbarna opened this issue Apr 26, 2023 · 0 comments · May be fixed by #82
Labels
bug Something isn't working

Comments

@tylerbarna
Copy link
Collaborator

When generating a lightcurve from a model, the sample times need to be provided as an argument both when the model is defined and when generate_lightcurve is called. Looking at the models in model.py, it would be sufficient to alter the code without having to provide the sample_times a second time (I imagine preserving the class parameter would touch less components outside of model.py)

@tylerbarna tylerbarna added this to the Analysis Tools milestone Jun 28, 2023
@tylerbarna tylerbarna added the bug Something isn't working label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant