Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewConn requires a delegate #189

Closed
isadon opened this issue Aug 26, 2016 · 1 comment
Closed

NewConn requires a delegate #189

isadon opened this issue Aug 26, 2016 · 1 comment
Labels

Comments

@isadon
Copy link

isadon commented Aug 26, 2016

Why does NewConn require a delegate interface? I put in nil for the parameter and get a nil pointer dereference crash in go-nsq. Considering that nil can be passed in for an interface I think the documentation for this method should state that its required.

@mreiferson
Copy link
Member

There's really no reason to ever use the NewConn interface, it probably shouldn't be exported but that ship has ⛵ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants