Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): ensure test target dependency is not duplicated #30289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cogwirrel
Copy link
Contributor

Current Behavior

Every time the vitest generator was run a new duplicate '^build' dependency was added to the target defaults for the test task.

Expected Behavior

No duplicate entries added!

Related Issue(s)

Fixes #30288

Every time the vitest generator was run a new duplicate '^build' dependency was added to the
target defaults for the test task. Updated to ensure it is specified only once.

Fixes nrwl#30288
@cogwirrel cogwirrel requested a review from a team as a code owner March 6, 2025 12:31
@cogwirrel cogwirrel requested a review from JamesHenry March 6, 2025 12:31
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 0:33am

Copy link

nx-cloud bot commented Mar 6, 2025

View your CI Pipeline Execution ↗ for commit 8d30cfc.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 32m 3s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=2d872... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 2m 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-06 13:09:48 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vitest generator adds duplicate ^build to test target default dependsOn
1 participant