Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS. Banana split backup. Has no restrictions for number of shards #2441

Open
stepanLav opened this issue Mar 7, 2025 · 0 comments
Open
Labels
Milestone

Comments

@stepanLav
Copy link
Member

stepanLav commented Mar 7, 2025

Environment: TestFlight
Version 6.3.2

Detail description:

There is no upper\lower boundary for "banana split" shards. That may lead to error.

The operation couldn't be completed.
(PolkadotVault.ServiceError error 1.)

Example:

RPReplay_Final1741007068.MP4

Scenario:

  1. Open Keyset
  2. Click ...
  3. Banana Split Backup
  4. Number of QR Code shards - enter high number, ex - 666

Actual result:
Fall in error - PolkadotVault.ServiceError error 1.

Expected result:
Has upper boundary for "banana split" shards

Additional information:
If user put 0 in the field it also shows the error

Error from banana split:

Error: Number of shares must be an integer between 2 and 2^bits-1 (255), inclusive. To create 666 shares, use at least 10 bits.

Image

@stepanLav stepanLav added this to the v6.3.2 milestone Mar 7, 2025
@stepanLav stepanLav added the ios label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant