Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate base Settings and move info to config crate #40

Open
luketchang opened this issue Mar 23, 2022 · 0 comments
Open

refactor: deprecate base Settings and move info to config crate #40

luketchang opened this issue Mar 23, 2022 · 0 comments
Labels
long-term refactor

Comments

@luketchang
Copy link
Collaborator

Should have something like BaseAgentSettings in configuration and then all the types with lots of functionality (e.g. CachingHome) implement From<BaseAgentSettings>. Overall, we should move from implementing <config struct>::into_<some struct with functionality> to implementing <struct with functionality>::from_<some config struct>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
long-term refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luketchang