Skip to content

Commit fd4bc58

Browse files
committedSep 15, 2024
fixup! esm: fix misleading error when import empty package.json
1 parent f7429fa commit fd4bc58

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
 

‎src/node_file.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -3432,8 +3432,8 @@ void BindingData::LegacyMainResolve(const FunctionCallbackInfo<Value>& args) {
34323432
}
34333433

34343434
THROW_ERR_MODULE_NOT_FOUND(isolate,
3435-
"No package entry point defined for package '%s' imported from %s",
3436-
package_json_url.value(),
3435+
"No package entry point defined for package %s imported from %s",
3436+
*utf8_package_json_url,
34373437
*module_base
34383438
);
34393439
}

‎test/es-module/test-import-empty.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ describe('Import empty module', { concurrency: true }, () => {
1818
assert.strictEqual(code, 1);
1919
assert.strictEqual(signal, null);
2020
assert.strictEqual(stdout, '');
21-
assert.match(stderr, /ERR_INVALID_MODULE/);
21+
assert.match(stderr, /No package entry point defined for package/);
2222
});
2323
});

0 commit comments

Comments
 (0)