Skip to content

Commit fbcf602

Browse files
mmarchiniMylesBorins
authored andcommittedMar 24, 2020
test: make test-memory-usage predictable
The current test relies on undeterministic behavior from V8 GC, and on newer versions of V8 this test ocasionally fails because that behavior changed. Prevent that from happening using --predictable-gc-schedule. If this test fails in the future, it should fail consistently instead of ocasionally, which should help debug. Ref: nodejs/node-v8#144 (comment) Signed-off-by: Matheus Marchini <[email protected]> PR-URL: #32239 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent 963ce08 commit fbcf602

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎test/parallel/test-memory-usage.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

22-
// Flags: --no-concurrent-array-buffer-freeing
22+
// Flags: --predictable-gc-schedule
2323
'use strict';
2424
const common = require('../common');
2525
const assert = require('assert');

0 commit comments

Comments
 (0)
Please sign in to comment.