Skip to content

Commit f9c84c5

Browse files
cjihrigMylesBorins
authored andcommitted
src: silence http2 -Wunused-result warnings
Backport-PR-URL: #18050 PR-URL: #17954 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 46f39b5 commit f9c84c5

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

src/node_http2.cc

+11-7
Original file line numberDiff line numberDiff line change
@@ -559,13 +559,13 @@ inline void Http2Stream::EmitStatistics() {
559559
FIXED_ONE_BYTE_STRING(env->isolate(), "timeToFirstByte"),
560560
Number::New(env->isolate(),
561561
(entry->first_byte() - entry->startTimeNano()) / 1e6),
562-
attr);
562+
attr).FromJust();
563563
obj->DefineOwnProperty(
564564
context,
565565
FIXED_ONE_BYTE_STRING(env->isolate(), "timeToFirstHeader"),
566566
Number::New(env->isolate(),
567567
(entry->first_header() - entry->startTimeNano()) / 1e6),
568-
attr);
568+
attr).FromJust();
569569
entry->Notify(obj);
570570
}
571571
delete entry;
@@ -591,25 +591,29 @@ inline void Http2Session::EmitStatistics() {
591591
String::NewFromUtf8(env->isolate(),
592592
entry->typeName(),
593593
v8::NewStringType::kInternalized)
594-
.ToLocalChecked(), attr);
594+
.ToLocalChecked(), attr).FromJust();
595595
if (entry->ping_rtt() != 0) {
596596
obj->DefineOwnProperty(
597597
context,
598598
FIXED_ONE_BYTE_STRING(env->isolate(), "pingRTT"),
599-
Number::New(env->isolate(), entry->ping_rtt() / 1e6), attr);
599+
Number::New(env->isolate(), entry->ping_rtt() / 1e6),
600+
attr).FromJust();
600601
}
601602
obj->DefineOwnProperty(
602603
context,
603604
FIXED_ONE_BYTE_STRING(env->isolate(), "framesReceived"),
604-
Integer::NewFromUnsigned(env->isolate(), entry->frame_count()), attr);
605+
Integer::NewFromUnsigned(env->isolate(), entry->frame_count()),
606+
attr).FromJust();
605607
obj->DefineOwnProperty(
606608
context,
607609
FIXED_ONE_BYTE_STRING(env->isolate(), "streamCount"),
608-
Integer::New(env->isolate(), entry->stream_count()), attr);
610+
Integer::New(env->isolate(), entry->stream_count()),
611+
attr).FromJust();
609612
obj->DefineOwnProperty(
610613
context,
611614
FIXED_ONE_BYTE_STRING(env->isolate(), "streamAverageDuration"),
612-
Number::New(env->isolate(), entry->stream_average_duration()), attr);
615+
Number::New(env->isolate(), entry->stream_average_duration()),
616+
attr).FromJust();
613617
entry->Notify(obj);
614618
}
615619
delete entry;

0 commit comments

Comments
 (0)