34
34
35
35
## Dependencies
36
36
37
- Node.js has several bundled dependencies in the * deps/ * and the * tools/ *
37
+ Node.js has several bundled dependencies in the _ deps/ _ and the _ tools/ _
38
38
directories that are not part of the project proper. Changes to files in those
39
39
directories should be sent to their respective projects. Do not send a patch to
40
40
Node.js. We cannot accept such patches.
@@ -161,33 +161,37 @@ notes about [commit squashing](#commit-squashing).
161
161
A good commit message should describe what changed and why.
162
162
163
163
1 . The first line should:
164
+
164
165
* contain a short description of the change (preferably 50 characters or
165
166
less, and no more than 72 characters)
166
167
* be entirely in lowercase with the exception of proper nouns, acronyms, and
167
- the words that refer to code, like function/variable names
168
+ the words that refer to code, like function/variable names
168
169
* be prefixed with the name of the changed [ subsystem] ( #appendix-subsystems )
169
- and start with an imperative verb. Check the output of `git log --oneline
170
- files/you/changed` to find out what subsystems your changes touch.
170
+ and start with an imperative verb. Check the output of `git log --oneline
171
+ files/you/changed` to find out what subsystems your changes touch.
171
172
172
173
Examples:
174
+
173
175
* ` net: add localAddress and localPort to Socket `
174
176
* ` src: fix typos in async_wrap.h `
175
177
176
178
2 . Keep the second line blank.
179
+
177
180
3 . Wrap all other lines at 72 columns (except for long URLs).
178
181
179
182
4 . If your patch fixes an open issue, you can add a reference to it at the end
180
183
of the log. Use the ` Fixes: ` prefix and the full issue URL. For other
181
184
references use ` Refs: ` .
182
185
183
186
Examples:
187
+
184
188
* ` Fixes: https://github.com/nodejs/node/issues/1337 `
185
189
* ` Refs: https://eslint.org/docs/rules/space-in-parens.html `
186
190
* ` Refs: https://github.com/nodejs/node/pull/3615 `
187
191
188
192
5 . If your commit introduces a breaking change (` semver-major ` ), it should
189
- contain an explanation about the reason of the breaking change, which
190
- situation would trigger the breaking change and what is the exact change.
193
+ contain an explanation about the reason of the breaking change, which
194
+ situation would trigger the breaking change and what is the exact change.
191
195
192
196
Sample complete commit message:
193
197
@@ -322,7 +326,7 @@ reviews a pull request they may find specific details that they would like to
322
326
see changed or fixed. These may be as simple as fixing a typo, or may involve
323
327
substantive changes to the code you have written. While such requests are
324
328
intended to be helpful, they may come across as abrupt or unhelpful, especially
325
- requests to change things that do not include concrete suggestions on * how * to
329
+ requests to change things that do not include concrete suggestions on _ how _ to
326
330
change them.
327
331
328
332
Try not to be discouraged. If you feel that a particular review is unfair,
@@ -384,7 +388,7 @@ Focus first on the most significant aspects of the change:
384
388
4 . Is the commit message readable and correct? If it contains a breaking change
385
389
is it clear enough?
386
390
387
- When changes are necessary, * request * them, do not * demand * them, and do not
391
+ When changes are necessary, _ request _ them, do not _ demand _ them, and do not
388
392
assume that the submitter already knows how to add a test or run a benchmark.
389
393
390
394
Specific performance optimization techniques, coding styles and conventions
@@ -404,7 +408,7 @@ with the appropriate reason to keep the conversation flow concise and relevant.
404
408
405
409
### Be aware of the person behind the code
406
410
407
- Be aware that * how * you communicate requests and reviews in your feedback can
411
+ Be aware that _ how _ you communicate requests and reviews in your feedback can
408
412
have a significant impact on the success of the pull request. Yes, we may land
409
413
a particular change that makes Node.js better, but the individual might just
410
414
not want to have anything to do with Node.js ever again. The goal is not just
@@ -446,7 +450,7 @@ or by leaving an `LGTM` ("Looks Good To Me") comment.
446
450
When explicitly using the "Changes requested" component of the GitHub Approval
447
451
Workflow, show empathy. That is, do not be rude or abrupt with your feedback
448
452
and offer concrete suggestions for improvement, if possible. If you're not
449
- sure * how * a particular change can be improved, say so.
453
+ sure _ how _ a particular change can be improved, say so.
450
454
451
455
Most importantly, after leaving such requests, it is courteous to make yourself
452
456
available later to check whether your comments have been addressed.
@@ -494,7 +498,7 @@ changing working functional code just for the sake of changing.
494
498
495
499
If a particular pull request introduces a performance or functional
496
500
regression, rather than simply rejecting the pull request, take the time to
497
- work * with * the contributor on improving the change. Offer feedback and
501
+ work _ with _ the contributor on improving the change. Offer feedback and
498
502
advice on what would make the pull request acceptable, and do not assume that
499
503
the contributor should already know how to do that. Be explicit in your
500
504
feedback.
0 commit comments