Skip to content

Commit e62a8b5

Browse files
danbevcodebytere
authored andcommittedJun 18, 2020
lib: update executionAsyncId/triggerAsyncId comment
This commit updates the comment referring to the executionAsyncId/triggerAsyncId pair being stored in a std::stack. It looks like this was changed from std::stack to AliasedFloat64Array in Commit 83e5215 ("async_hooks: use typed array stack as fast path"). PR-URL: #33396 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 9b7ba87 commit e62a8b5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed
 

‎lib/internal/async_hooks.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ const {
4141
execution_async_resources,
4242
owner_symbol
4343
} = async_wrap;
44-
// Store the pair executionAsyncId and triggerAsyncId in a std::stack on
45-
// Environment::AsyncHooks::async_ids_stack_ tracks the resource responsible for
46-
// the current execution stack. This is unwound as each resource exits. In the
47-
// case of a fatal exception this stack is emptied after calling each hook's
48-
// after() callback.
44+
// Store the pair executionAsyncId and triggerAsyncId in a AliasedFloat64Array
45+
// in Environment::AsyncHooks::async_ids_stack_ which tracks the resource
46+
// responsible for the current execution stack. This is unwound as each resource
47+
// exits. In the case of a fatal exception this stack is emptied after calling
48+
// each hook's after() callback.
4949
const {
5050
pushAsyncContext: pushAsyncContext_,
5151
popAsyncContext: popAsyncContext_

0 commit comments

Comments
 (0)
Please sign in to comment.