Skip to content

Commit e2aa879

Browse files
legendecasUlisesGascon
authored andcommitted
deps: V8: cherry-pick 0f9ebbc672c7
Original commit message: [flags] Remove --harmony-string-is-well-formed The String.prototype.isWellFormed and toWellFormed have shipped since M111. Bug: v8:13557 Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Chengzhong Wu (legendecas) <[email protected]> Cr-Commit-Position: refs/heads/main@{#90398} Refs: v8/v8@0f9ebbc PR-URL: #50867 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
1 parent 83f1294 commit e2aa879

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.15',
39+
'v8_embedder_string': '-node.17',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/flags/flag-definitions.h

-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,6 @@ DEFINE_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab)
274274
V(harmony_import_assertions, "harmony import assertions") \
275275
V(harmony_symbol_as_weakmap_key, "harmony symbols as weakmap keys") \
276276
V(harmony_change_array_by_copy, "harmony change-Array-by-copy") \
277-
V(harmony_string_is_well_formed, "harmony String#{is,to}WellFormed") \
278277
V(harmony_rab_gsab, \
279278
"harmony ResizableArrayBuffer / GrowableSharedArrayBuffer") \
280279
V(harmony_regexp_unicode_sets, "harmony RegExp Unicode Sets")

deps/v8/src/init/bootstrapper.cc

+4-12
Original file line numberDiff line numberDiff line change
@@ -2114,6 +2114,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
21142114
Builtin::kStringPrototypeIncludes, 1, false);
21152115
SimpleInstallFunction(isolate_, prototype, "indexOf",
21162116
Builtin::kStringPrototypeIndexOf, 1, false);
2117+
SimpleInstallFunction(isolate(), prototype, "isWellFormed",
2118+
Builtin::kStringPrototypeIsWellFormed, 0, false);
21172119
SimpleInstallFunction(isolate_, prototype, "italics",
21182120
Builtin::kStringPrototypeItalics, 0, false);
21192121
SimpleInstallFunction(isolate_, prototype, "lastIndexOf",
@@ -2170,6 +2172,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
21702172
Builtin::kStringPrototypeStartsWith, 1, false);
21712173
SimpleInstallFunction(isolate_, prototype, "toString",
21722174
Builtin::kStringPrototypeToString, 0, true);
2175+
SimpleInstallFunction(isolate(), prototype, "toWellFormed",
2176+
Builtin::kStringPrototypeToWellFormed, 0, false);
21732177
SimpleInstallFunction(isolate_, prototype, "trim",
21742178
Builtin::kStringPrototypeTrim, 0, false);
21752179

@@ -4959,18 +4963,6 @@ void Genesis::InitializeGlobal_harmony_rab_gsab() {
49594963
Builtin::kSharedArrayBufferPrototypeGrow, 1, true);
49604964
}
49614965

4962-
void Genesis::InitializeGlobal_harmony_string_is_well_formed() {
4963-
if (!v8_flags.harmony_string_is_well_formed) return;
4964-
Handle<JSFunction> string_function(native_context()->string_function(),
4965-
isolate());
4966-
Handle<JSObject> string_prototype(
4967-
JSObject::cast(string_function->initial_map().prototype()), isolate());
4968-
SimpleInstallFunction(isolate(), string_prototype, "isWellFormed",
4969-
Builtin::kStringPrototypeIsWellFormed, 0, false);
4970-
SimpleInstallFunction(isolate(), string_prototype, "toWellFormed",
4971-
Builtin::kStringPrototypeToWellFormed, 0, false);
4972-
}
4973-
49744966
void Genesis::InitializeGlobal_harmony_temporal() {
49754967
if (!v8_flags.harmony_temporal) return;
49764968
// -- T e m p o r a l

0 commit comments

Comments
 (0)