fs: fix length option being ignored during read()

Currently, `length` in an options object is ignored.

PR-URL: #40906
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Author: fracsinus

lib/internal/fs/promises.js

@@ -520,7 +520,7 @@ async function read(handle, bufferOrOptions, offset, length, position) {
       buffer = Buffer.alloc(16384);
     }
     offset = bufferOrOptions.offset || 0;
-    length = buffer.byteLength;
+    length = bufferOrOptions.length ?? buffer.byteLength;
     position = bufferOrOptions.position ?? null;
   }
 

test/parallel/test-fs-promises-file-handle-read.js

@@ -87,6 +87,15 @@ async function validateReadWithPositionZero() {
   }
 }
 
+async function validateReadLength(len) {
+  const buf = Buffer.alloc(4);
+  const opts = { useConf: true };
+  const filePath = fixtures.path('x.txt');
+  const fileHandle = await open(filePath, 'r');
+  const { bytesRead } = await read(fileHandle, buf, 0, len, 0, opts);
+  assert.strictEqual(bytesRead, len);
+}
+
 
 (async function() {
   tmpdir.refresh();
@@ -98,4 +107,6 @@ async function validateReadWithPositionZero() {
   await validateLargeRead({ useConf: true });
   await validateReadNoParams();
   await validateReadWithPositionZero();
+  await validateReadLength(0);
+  await validateReadLength(1);
 })().then(common.mustCall());