Skip to content

Commit df6acf9

Browse files
addaleaxMylesBorins
authored andcommitted
src: remove tracking for exception arrow data
This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway. PR-URL: #17394 Reviewed-By: James M Snell <[email protected]>
1 parent e63e4a1 commit df6acf9

File tree

3 files changed

+1
-14
lines changed

3 files changed

+1
-14
lines changed

src/env.h

-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ class ModuleWrap;
9191
V(contextify_global_private_symbol, "node:contextify:global") \
9292
V(decorated_private_symbol, "node:decorated") \
9393
V(npn_buffer_private_symbol, "node:npnBuffer") \
94-
V(processed_private_symbol, "node:processed") \
9594
V(selected_npn_buffer_private_symbol, "node:selectedNpnBuffer") \
9695
V(domain_private_symbol, "node:domain") \
9796

src/node.cc

-10
Original file line numberDiff line numberDiff line change
@@ -1629,16 +1629,6 @@ void AppendExceptionLine(Environment* env,
16291629
Local<Object> err_obj;
16301630
if (!er.IsEmpty() && er->IsObject()) {
16311631
err_obj = er.As<Object>();
1632-
1633-
auto context = env->context();
1634-
auto processed_private_symbol = env->processed_private_symbol();
1635-
// Do it only once per message
1636-
if (err_obj->HasPrivate(context, processed_private_symbol).FromJust())
1637-
return;
1638-
err_obj->SetPrivate(
1639-
context,
1640-
processed_private_symbol,
1641-
True(env->isolate()));
16421632
}
16431633

16441634
// Print (filename):(line number): (message).

src/node_contextify.cc

+1-3
Original file line numberDiff line numberDiff line change
@@ -701,9 +701,7 @@ class ContextifyScript : public BaseObject {
701701
compile_options);
702702

703703
if (v8_script.IsEmpty()) {
704-
if (display_errors) {
705-
DecorateErrorStack(env, try_catch);
706-
}
704+
DecorateErrorStack(env, try_catch);
707705
try_catch.ReThrow();
708706
return;
709707
}

0 commit comments

Comments
 (0)