Skip to content

Commit d99ea48

Browse files
kvakiljuanarbol
authored andcommitted
src: remove kEagerCompile for CompileFunction
It wasn't doing anything, and actually enabling it would cause some tests to fail. Refs: #48576 PR-URL: #48671 Refs: v8/v8@cb00db4 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent 67b13d1 commit d99ea48

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/node_builtins.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
285285
const bool has_cache = cached_data.data != nullptr;
286286
ScriptCompiler::CompileOptions options =
287287
has_cache ? ScriptCompiler::kConsumeCodeCache
288-
: ScriptCompiler::kEagerCompile;
288+
: ScriptCompiler::kNoCompileOptions;
289289
ScriptCompiler::Source script_source(
290290
source,
291291
origin,

src/node_snapshotable.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1270,7 +1270,7 @@ void CompileSerializeMain(const FunctionCallbackInfo<Value>& args) {
12701270
parameters.data(),
12711271
0,
12721272
nullptr,
1273-
ScriptCompiler::kEagerCompile)
1273+
ScriptCompiler::kNoCompileOptions)
12741274
.ToLocal(&fn)) {
12751275
args.GetReturnValue().Set(fn);
12761276
}

0 commit comments

Comments
 (0)