process: delay process.argv[0] and process.argv0 handling

Since these depends on process runtime states, delay them until
pre-execution.

PR-URL: #26517
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

Author: joyeecheung

lib/internal/bootstrap/node.js

@@ -206,13 +206,6 @@ if (!config.noBrowserGlobals) {
   defineOperation(global, 'setImmediate', timers.setImmediate);
 }
 
-Object.defineProperty(process, 'argv0', {
-  enumerable: true,
-  configurable: false,
-  value: process.argv[0]
-});
-process.argv[0] = process.execPath;
-
 // TODO(jasnell): The following have been globals since around 2012.
 // That's just silly. The underlying perfctr support has been removed
 // so these are now deprecated non-ops that can be removed after one

lib/internal/bootstrap/pre_execution.js

@@ -3,6 +3,8 @@
 const { getOptionValue } = require('internal/options');
 
 function prepareMainThreadExecution() {
+  // Patch the process object with legacy properties and normalizations
+  patchProcessObject();
   setupTraceCategoryState();
 
   setupWarningHandler();
@@ -59,6 +61,15 @@ function prepareMainThreadExecution() {
   loadPreloadModules();
 }
 
+function patchProcessObject() {
+  Object.defineProperty(process, 'argv0', {
+    enumerable: true,
+    configurable: false,
+    value: process.argv[0]
+  });
+  process.argv[0] = process.execPath;
+}
+
 function setupWarningHandler() {
   const {
     onWarning
@@ -307,6 +318,7 @@ function loadPreloadModules() {
 }
 
 module.exports = {
+  patchProcessObject,
   setupCoverageHooks,
   setupWarningHandler,
   setupDebugEnv,

lib/internal/main/worker_thread.js

@@ -4,6 +4,7 @@
 // message port.
 
 const {
+  patchProcessObject,
   setupCoverageHooks,
   setupWarningHandler,
   setupDebugEnv,
@@ -41,6 +42,7 @@ const {
 
 const publicWorker = require('worker_threads');
 
+patchProcessObject();
 setupDebugEnv();
 
 const debug = require('util').debuglog('worker');