Skip to content

Commit caad474

Browse files
joyeecheungRafaelGSS
authored andcommitted
tools: increase timeout of running WPT
We run all WPT from one subset in the same process using workers. As the number of the tests grow, it can take longer to run some of the subsets, but it's still overall faster than running them in different processes. This patch increases the timeout for WPT to prevent the test from failing because it takes longer to run (even though it would still complete at some point). PR-URL: #44574 Refs: nodejs/reliability#371 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 2813323 commit caad474

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tools/test.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -957,8 +957,14 @@ def GetVm(self, arch, mode):
957957

958958
def GetTimeout(self, mode, section=''):
959959
timeout = self.timeout * TIMEOUT_SCALEFACTOR[ARCH_GUESS or 'ia32'][mode]
960-
if section == 'pummel' or section == 'benchmark' or section == 'wpt':
960+
if section == 'pummel' or section == 'benchmark':
961961
timeout = timeout * 6
962+
# We run all WPT from one subset in the same process using workers.
963+
# As the number of the tests grow, it can take longer to run some of the
964+
# subsets, but it's still overall faster than running them in different
965+
# processes.
966+
elif section == 'wpt':
967+
timeout = timeout * 12
962968
return timeout
963969

964970
def RunTestCases(cases_to_run, progress, tasks, flaky_tests_mode, measure_flakiness):

0 commit comments

Comments
 (0)