Skip to content

Commit c9e09ad

Browse files
joyeecheungevanlucas
authored andcommitted
doc: improve the instructions of onboarding PR
PR-URL: #18268 Fixes: #18090 Refs: nodejs/TSC#472 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
1 parent 693159e commit c9e09ad

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

doc/onboarding.md

+7-5
Original file line numberDiff line numberDiff line change
@@ -199,12 +199,13 @@ onboarding session.
199199
* Optionally, include your personal pronouns.
200200
* Label your pull request with the `doc` subsystem label.
201201
* Run CI on your PR.
202-
* After one or two approvals, land the PR.
202+
* After one or two approvals, land the PR (PRs of this type do not need to wait
203+
for 48/72 hours to land).
203204
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
204-
metadata!
205-
* [`core-validate-commit`][] helps a lot with this – install and use it if you
206-
can!
207-
* [`node-core-utils`][] fetches the metadata for you.
205+
metadata.
206+
* [`core-validate-commit`][] automates the validation of commit messages.
207+
* [`node-core-utils`][] automates the generation of metadata and the landing
208+
process. See the documentation of [`git-node`][].
208209

209210
## Final notes
210211

@@ -227,6 +228,7 @@ onboarding session.
227228

228229
[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
229230
[`core-validate-commit`]: https://github.com/evanlucas/core-validate-commit
231+
[`git-node`]: https://github.com/nodejs/node-core-utils#git-node
230232
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
231233
[Landing Pull Requests]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests
232234
[https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0]: https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0

0 commit comments

Comments
 (0)