Skip to content

Commit bab9c4d

Browse files
KhafraDevtargos
authored andcommitted
events: getMaxListeners detects 0 listeners
PR-URL: #56807 Refs: nodejs/undici#4032 Refs: c1ccade Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
1 parent 3af23a1 commit bab9c4d

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/events.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@ function getEventListeners(emitterOrTarget, type) {
939939
function getMaxListeners(emitterOrTarget) {
940940
if (typeof emitterOrTarget?.getMaxListeners === 'function') {
941941
return _getMaxListeners(emitterOrTarget);
942-
} else if (emitterOrTarget?.[kMaxEventTargetListeners]) {
942+
} else if (typeof emitterOrTarget?.[kMaxEventTargetListeners] === 'number') {
943943
return emitterOrTarget[kMaxEventTargetListeners];
944944
}
945945

test/parallel/test-events-getmaxlisteners.js

+5
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,8 @@ const { getMaxListeners, EventEmitter, defaultMaxListeners, setMaxListeners } =
1717
setMaxListeners(101, et);
1818
assert.strictEqual(getMaxListeners(et), 101);
1919
}
20+
21+
{
22+
const ac = new AbortController();
23+
assert.strictEqual(getMaxListeners(ac.signal), 0);
24+
}

0 commit comments

Comments
 (0)