Skip to content

Commit ba46103

Browse files
lpincaMylesBorins
authored andcommitted
stream: fix misleading error message
The method to implement is `_write` not `_transform`. PR-URL: #18604 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent 15db296 commit ba46103

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

lib/_stream_writable.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ function clearBuffer(stream, state) {
551551
}
552552

553553
Writable.prototype._write = function(chunk, encoding, cb) {
554-
cb(new errors.Error('ERR_METHOD_NOT_IMPLEMENTED', '_transform'));
554+
cb(new errors.Error('ERR_METHOD_NOT_IMPLEMENTED', '_write'));
555555
};
556556

557557
Writable.prototype._writev = null;

test/parallel/test-stream-writable-constructor-set-methods.js

+11-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
require('../common');
2+
const common = require('../common');
33
const assert = require('assert');
44

55
const Writable = require('stream').Writable;
@@ -26,6 +26,16 @@ w2.write(Buffer.from('blerg'));
2626
w2.write(Buffer.from('blerg'));
2727
w2.end();
2828

29+
const w3 = new Writable();
30+
31+
w3.on('error', common.expectsError({
32+
type: Error,
33+
code: 'ERR_METHOD_NOT_IMPLEMENTED',
34+
message: 'The _write method is not implemented'
35+
}));
36+
37+
w3.end(Buffer.from('blerg'));
38+
2939
process.on('exit', function() {
3040
assert.strictEqual(w._write, _write);
3141
assert(_writeCalled);

0 commit comments

Comments
 (0)