Skip to content

Commit b19d19e

Browse files
TrottFishrock123
authored andcommitted
test: extend timeout in Debug mode
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-GH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-GH-5504.js. PR-URL: #4431 Reviewed-By: Johan Bergström <[email protected]>
1 parent 9e66735 commit b19d19e

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

test/common.js

+3
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,9 @@ exports.spawnPwd = function(options) {
255255
};
256256

257257
exports.platformTimeout = function(ms) {
258+
if (process.config.target_defaults.default_configuration === 'Debug')
259+
ms = 2 * ms;
260+
258261
if (process.arch !== 'arm')
259262
return ms;
260263

test/sequential/test-net-GH-5504.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22
var common = require('../common');
3-
var assert = require('assert');
43

54
// this test only fails with CentOS 6.3 using kernel version 2.6.32
65
// On other linuxes and darwin, the `read` call gets an ECONNRESET in

0 commit comments

Comments
 (0)