Skip to content

Commit b015747

Browse files
guybedfordMylesBorins
authored andcommitted
doc: esm loader example with module.builtinModules
PR-URL: #17385 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
1 parent 8c21430 commit b015747

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

doc/api/esm.md

+3-5
Original file line numberDiff line numberDiff line change
@@ -147,15 +147,13 @@ be written:
147147
import url from 'url';
148148
import path from 'path';
149149
import process from 'process';
150+
import Module from 'module';
150151

151-
const builtins = new Set(
152-
Object.keys(process.binding('natives')).filter((str) =>
153-
/^(?!(?:internal|node|v8)\/)/.test(str))
154-
);
152+
const builtins = Module.builtinModules;
155153
const JS_EXTENSIONS = new Set(['.js', '.mjs']);
156154

157155
export function resolve(specifier, parentModuleURL/*, defaultResolve */) {
158-
if (builtins.has(specifier)) {
156+
if (builtins.includes(specifier)) {
159157
return {
160158
url: specifier,
161159
format: 'builtin'

0 commit comments

Comments
 (0)