Skip to content

Commit ae9d5fd

Browse files
ShogunPandajuanarbol
authored andcommitted
doc: document breaking change in http.IncomingMessage 'close' event
PR-URL: #42521 Fixes: #38924 Refs: #33035 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1 parent 98f1f34 commit ae9d5fd

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

doc/api/http.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -2106,9 +2106,14 @@ Emitted when the request has been aborted.
21062106

21072107
<!-- YAML
21082108
added: v0.4.2
2109+
changes:
2110+
- version: v16.0.0
2111+
pr-url: https://github.com/nodejs/node/pull/33035
2112+
description: The close event is now emitted when the request has been completed and not when the
2113+
underlying socket is closed.
21092114
-->
21102115

2111-
Indicates that the underlying connection was closed.
2116+
Emitted when the request has been completed.
21122117

21132118
### `message.aborted`
21142119

doc/changelogs/CHANGELOG_V16.md

+1
Original file line numberDiff line numberDiff line change
@@ -1600,6 +1600,7 @@ Contributed by Michaël Zasso - [#37587](https://github.com/nodejs/node/pull/375
16001600
* **deps**: update llhttp to 6.0.0 (Fedor Indutny) [#38277](https://github.com/nodejs/node/pull/38277)
16011601
* **deps**: upgrade npm to 7.10.0 (Ruy Adorno) [#38254](https://github.com/nodejs/node/pull/38254)
16021602
* **(SEMVER-MINOR)** **http**: add http.ClientRequest.getRawHeaderNames() (simov) [#37660](https://github.com/nodejs/node/pull/37660)
1603+
* **(SEMVER-MAJOR)** **http**: use `autoDestroy: true` in incoming message (Daniele Belardi) [#33035](https://github.com/nodejs/node/pull/33035)
16031604
* **(SEMVER-MAJOR)** **lib,src**: update cluster to use Parent (Michael Dawson) [#36478](https://github.com/nodejs/node/pull/36478)
16041605
* **(SEMVER-MINOR)** **module**: add support for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246](https://github.com/nodejs/node/pull/37246)
16051606
* **(SEMVER-MINOR)** **perf\_hooks**: add histogram option to timerify (James M Snell) [#37475](https://github.com/nodejs/node/pull/37475)

0 commit comments

Comments
 (0)