Skip to content

Commit 99e6734

Browse files
TrottMylesBorins
authored andcommitted
doc: improve best practices in onboarding-extras
PR-URL: #19315 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 5a56327 commit 99e6734

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

doc/onboarding-extras.md

+3-6
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,7 @@ to update from nodejs/node:
142142
* `git remote update -p` OR `git fetch --all` (I prefer the former)
143143
* `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
144144

145-
## best practices
145+
## Best practices
146146

147-
* commit often, out to your github fork (origin), open a PR
148-
* when making PRs make sure to spend time on the description:
149-
* every moment you spend writing a good description quarters the amount of
150-
time it takes to understand your code.
151-
* usually prefer to only squash at the *end* of your work, depends on the change
147+
* When making PRs, spend time writing a thorough description.
148+
* Usually only squash at the end of your work.

0 commit comments

Comments
 (0)