Skip to content

Commit 9265f4b

Browse files
Nate-weekstargos
authored andcommitted
test: remove string literal from assertions
PR-URL: #19276 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
1 parent 7e9b7a5 commit 9265f4b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/parallel/test-crypto-sign-verify.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ common.expectsError(
6565
.update('Test')
6666
.update('123')
6767
.verify(certPem, s1, 'base64');
68-
assert.strictEqual(verified, true, 'sign and verify (base 64)');
68+
assert.strictEqual(verified, true);
6969
}
7070

7171
{
@@ -81,14 +81,14 @@ common.expectsError(
8181
.update('Test')
8282
.update('123')
8383
.verify(certPem, s2, 'latin1');
84-
assert.strictEqual(verified, true, 'sign and verify (latin1)');
84+
assert.strictEqual(verified, true);
8585

8686
const verStream = crypto.createVerify('SHA256');
8787
verStream.write('Tes');
8888
verStream.write('t12');
8989
verStream.end('3');
9090
verified = verStream.verify(certPem, s2, 'latin1');
91-
assert.strictEqual(verified, true, 'sign and verify (stream)');
91+
assert.strictEqual(verified, true);
9292
}
9393

9494
{
@@ -99,14 +99,14 @@ common.expectsError(
9999
.update('Test')
100100
.update('123')
101101
.verify(certPem, s3);
102-
assert.strictEqual(verified, true, 'sign and verify (buffer)');
102+
assert.strictEqual(verified, true);
103103

104104
const verStream = crypto.createVerify('SHA1');
105105
verStream.write('Tes');
106106
verStream.write('t12');
107107
verStream.end('3');
108108
verified = verStream.verify(certPem, s3);
109-
assert.strictEqual(verified, true, 'sign and verify (stream)');
109+
assert.strictEqual(verified, true);
110110
}
111111

112112
// Special tests for RSA_PKCS1_PSS_PADDING
@@ -177,7 +177,7 @@ common.expectsError(
177177
}, s4);
178178
const saltLengthCorrect = getEffectiveSaltLength(signSaltLength) ===
179179
getEffectiveSaltLength(verifySaltLength);
180-
assert.strictEqual(verified, saltLengthCorrect, 'verify (PSS)');
180+
assert.strictEqual(verified, saltLengthCorrect);
181181
});
182182

183183
// Verification using RSA_PSS_SALTLEN_AUTO should always work
@@ -188,7 +188,7 @@ common.expectsError(
188188
padding: crypto.constants.RSA_PKCS1_PSS_PADDING,
189189
saltLength: crypto.constants.RSA_PSS_SALTLEN_AUTO
190190
}, s4);
191-
assert.strictEqual(verified, true, 'verify (PSS with SALTLEN_AUTO)');
191+
assert.strictEqual(verified, true);
192192

193193
// Verifying an incorrect message should never work
194194
verified = crypto.createVerify(algo)
@@ -198,7 +198,7 @@ common.expectsError(
198198
padding: crypto.constants.RSA_PKCS1_PSS_PADDING,
199199
saltLength: crypto.constants.RSA_PSS_SALTLEN_AUTO
200200
}, s4);
201-
assert.strictEqual(verified, false, 'verify (PSS, incorrect)');
201+
assert.strictEqual(verified, false);
202202
}
203203
});
204204
}
@@ -219,7 +219,7 @@ common.expectsError(
219219
padding: crypto.constants.RSA_PKCS1_PSS_PADDING,
220220
saltLength: vector.salt.length / 2
221221
}, vector.signature, 'hex');
222-
assert.strictEqual(verified, true, 'verify (PSS)');
222+
assert.strictEqual(verified, true);
223223
}
224224

225225
const examples = JSON.parse(fixtures.readSync('pss-vectors.json', 'utf8'));

0 commit comments

Comments
 (0)