Skip to content

Commit 8e5b711

Browse files
BridgeARMylesBorins
authored andcommitted
tools: prohibit notDeepEqual usage
PR-URL: #16325 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 36e2643 commit 8e5b711

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

.eslintrc.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ rules:
5656
- object: assert
5757
property: deepEqual
5858
message: Use assert.deepStrictEqual().
59+
- object: assert
60+
property: notDeepEqual
61+
message: Use assert.notDeepStrictEqual().
5962
- object: assert
6063
property: equal
6164
message: Use assert.strictEqual() rather than assert.equal().

lib/assert.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -101,20 +101,20 @@ assert.deepEqual = function deepEqual(actual, expected, message) {
101101
innerFail(actual, expected, message, 'deepEqual', deepEqual);
102102
}
103103
};
104-
/* eslint-enable */
105-
106-
assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
107-
if (!isDeepStrictEqual(actual, expected)) {
108-
innerFail(actual, expected, message, 'deepStrictEqual', deepStrictEqual);
109-
}
110-
};
111104

112105
// The non-equivalence assertion tests for any deep inequality.
113106
assert.notDeepEqual = function notDeepEqual(actual, expected, message) {
114107
if (isDeepEqual(actual, expected)) {
115108
innerFail(actual, expected, message, 'notDeepEqual', notDeepEqual);
116109
}
117110
};
111+
/* eslint-enable */
112+
113+
assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
114+
if (!isDeepStrictEqual(actual, expected)) {
115+
innerFail(actual, expected, message, 'deepStrictEqual', deepStrictEqual);
116+
}
117+
};
118118

119119
assert.notDeepStrictEqual = notDeepStrictEqual;
120120
function notDeepStrictEqual(actual, expected, message) {

0 commit comments

Comments
 (0)