Skip to content

Commit 8a2b4ee

Browse files
verwaestcjihrig
authored andcommitted
src: remove unnecessary call to SetHiddenPrototype
Currently the template for the global object is explicitly marked as hidden. This is unnecessary since the global object is automatically marked as hidden by V8. Getting rid of this call gets rid of the last use of SetHiddenPrototype. PR-URL: #16554 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
1 parent 2bb148f commit 8a2b4ee

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/node_contextify.cc

-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ class ContextifyContext {
139139
EscapableHandleScope scope(env->isolate());
140140
Local<FunctionTemplate> function_template =
141141
FunctionTemplate::New(env->isolate());
142-
function_template->SetHiddenPrototype(true);
143142

144143
function_template->SetClassName(sandbox_obj->GetConstructorName());
145144

0 commit comments

Comments
 (0)