Skip to content

Commit 88f4bf2

Browse files
BridgeARevanlucas
authored andcommitted
benchmark: (process) use destructuring
PR-URL: #18250 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f491828 commit 88f4bf2

9 files changed

+23
-27
lines changed

benchmark/process/bench-env.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ const bench = common.createBenchmark(main, {
77
});
88

99

10-
function main(conf) {
11-
const n = conf.n >>> 0;
10+
function main({ n }) {
1211
bench.start();
1312
for (var i = 0; i < n; i++) {
1413
// Access every item in object to process values.

benchmark/process/bench-hrtime.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@ const bench = common.createBenchmark(main, {
88
type: ['raw', 'diff']
99
});
1010

11-
function main(conf) {
12-
const n = conf.n | 0;
11+
function main({ n, type }) {
1312
const hrtime = process.hrtime;
1413
var noDead = hrtime();
1514
var i;
1615

17-
if (conf.type === 'raw') {
16+
if (type === 'raw') {
1817
bench.start();
1918
for (i = 0; i < n; i++) {
2019
noDead = hrtime();

benchmark/process/memoryUsage.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ const bench = common.createBenchmark(main, {
55
n: [1e5]
66
});
77

8-
function main(conf) {
9-
const n = +conf.n;
10-
8+
function main({ n }) {
119
bench.start();
1210
for (var i = 0; i < n; i++) {
1311
process.memoryUsage();

benchmark/process/next-tick-breadth-args.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ const bench = common.createBenchmark(main, {
55
millions: [4]
66
});
77

8-
function main(conf) {
9-
const N = +conf.millions * 1e6;
8+
function main({ millions }) {
9+
const N = millions * 1e6;
1010
var n = 0;
1111

1212
function cb1(arg1) {

benchmark/process/next-tick-breadth.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ const bench = common.createBenchmark(main, {
55
millions: [4]
66
});
77

8-
function main(conf) {
9-
const N = +conf.millions * 1e6;
8+
function main({ millions }) {
9+
const N = millions * 1e6;
1010
var n = 0;
1111

1212
function cb() {

benchmark/process/next-tick-depth-args.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ const bench = common.createBenchmark(main, {
77

88
process.maxTickDepth = Infinity;
99

10-
function main(conf) {
11-
var n = +conf.millions * 1e6;
10+
function main({ millions }) {
11+
var n = millions * 1e6;
1212

1313
function cb4(arg1, arg2, arg3, arg4) {
1414
if (--n) {
@@ -21,7 +21,7 @@ function main(conf) {
2121
else
2222
process.nextTick(cb1, 0);
2323
} else
24-
bench.end(+conf.millions);
24+
bench.end(millions);
2525
}
2626
function cb3(arg1, arg2, arg3) {
2727
if (--n) {
@@ -34,7 +34,7 @@ function main(conf) {
3434
else
3535
process.nextTick(cb1, 0);
3636
} else
37-
bench.end(+conf.millions);
37+
bench.end(millions);
3838
}
3939
function cb2(arg1, arg2) {
4040
if (--n) {
@@ -47,7 +47,7 @@ function main(conf) {
4747
else
4848
process.nextTick(cb1, 0);
4949
} else
50-
bench.end(+conf.millions);
50+
bench.end(millions);
5151
}
5252
function cb1(arg1) {
5353
if (--n) {
@@ -60,7 +60,7 @@ function main(conf) {
6060
else
6161
process.nextTick(cb1, 0);
6262
} else
63-
bench.end(+conf.millions);
63+
bench.end(millions);
6464
}
6565
bench.start();
6666
process.nextTick(cb1, true);

benchmark/process/next-tick-depth.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ const bench = common.createBenchmark(main, {
66

77
process.maxTickDepth = Infinity;
88

9-
function main(conf) {
10-
var n = +conf.millions * 1e6;
9+
function main({ millions }) {
10+
var n = millions * 1e6;
1111

1212
bench.start();
1313
process.nextTick(onNextTick);
1414
function onNextTick() {
1515
if (--n)
1616
process.nextTick(onNextTick);
1717
else
18-
bench.end(+conf.millions);
18+
bench.end(millions);
1919
}
2020
}

benchmark/process/next-tick-exec-args.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ const bench = common.createBenchmark(main, {
44
millions: [5]
55
});
66

7-
function main(conf) {
8-
var n = +conf.millions * 1e6;
7+
function main({ millions }) {
8+
var n = millions * 1e6;
99

1010
bench.start();
1111
for (var i = 0; i < n; i++) {
@@ -20,6 +20,6 @@ function main(conf) {
2020
}
2121
function onNextTick(i) {
2222
if (i + 1 === n)
23-
bench.end(+conf.millions);
23+
bench.end(millions);
2424
}
2525
}

benchmark/process/next-tick-exec.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ const bench = common.createBenchmark(main, {
44
millions: [5]
55
});
66

7-
function main(conf) {
8-
var n = +conf.millions * 1e6;
7+
function main({ millions }) {
8+
var n = millions * 1e6;
99

1010
bench.start();
1111
for (var i = 0; i < n; i++) {
1212
process.nextTick(onNextTick, i);
1313
}
1414
function onNextTick(i) {
1515
if (i + 1 === n)
16-
bench.end(+conf.millions);
16+
bench.end(millions);
1717
}
1818
}

0 commit comments

Comments
 (0)