buffer: don't predefine error

PR-URL: #17021
Fixes: #16994
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Author: ah-yu

lib/buffer.js

@@ -449,14 +449,12 @@ Buffer.isEncoding = function isEncoding(encoding) {
 };
 Buffer[kIsEncodingSymbol] = Buffer.isEncoding;
 
-const kConcatErr = new errors.TypeError(
-  'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
-);
-
 Buffer.concat = function concat(list, length) {
   var i;
   if (!Array.isArray(list))
-    throw kConcatErr;
+    throw new errors.TypeError(
+      'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
+    );
 
   if (list.length === 0)
     return new FastBuffer();
@@ -474,7 +472,9 @@ Buffer.concat = function concat(list, length) {
   for (i = 0; i < list.length; i++) {
     var buf = list[i];
     if (!isUint8Array(buf))
-      throw kConcatErr;
+      throw new errors.TypeError(
+        'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
+      );
     _copy(buf, buffer, pos);
     pos += buf.length;
   }