Skip to content

Commit 7fcc1f7

Browse files
committedOct 7, 2019
src: update NODE_MODULE_VERSION to 79
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #29694 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
1 parent 60a3bd9 commit 7fcc1f7

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed
 

‎doc/abi_version_registry.json

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"NODE_MODULE_VERSION": [
3+
{ "modules": 79, "runtime": "node", "variant": "v8_7.8", "versions": "13.0.0-pre" },
34
{ "modules": 78, "runtime": "node", "variant": "v8_7.7", "versions": "13.0.0-pre" },
45
{ "modules": 77, "runtime": "node", "variant": "v8_7.6", "versions": "13.0.0-pre" },
56
{ "modules": 76, "runtime": "electron", "variant": "electron", "versions": "8" },

‎src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
* version matching should open a pull request to reserve a number in this
9090
* registry.
9191
*/
92-
#define NODE_MODULE_VERSION 78
92+
#define NODE_MODULE_VERSION 79
9393

9494
// The NAPI_VERSION provided by this version of the runtime. This is the version
9595
// which the Node binary being built supports.

0 commit comments

Comments
 (0)
Please sign in to comment.