Skip to content

Commit 7f68e14

Browse files
kvakiltargos
authored andcommitted
child_process: improve spawn performance on Linux
Speed up child_process.spawn by enabling the new V8 build flag which makes fork/exec faster. Here are the results of running the existing benchmark. Note that this optimization helps more for applications with larger heaps, so this is somewhat of an underestimate of the real world performance benefits. ```console $ ./node benchmark/compare.js --runs 15 \ --new ./node \ --old ~/node-v20/out/Release/node \ --filter params child_process > cpr $ node-benchmark-compare cpr confidence improvement (***) methodName='exec' n=1000 *** 60.84 % ±5.43% methodName='execFile' n=1000 *** 53.72 % ±3.33% methodName='execFileSync' n=1000 *** 9.10 % ±0.84% methodName='execSync' n=1000 *** 10.44 % ±0.97% methodName='spawn' n=1000 *** 53.10 % ±2.90% methodName='spawnSync' n=1000 *** 8.64 % ±1.22% 0.01 false positives, when considering a 0.1% risk acceptance (***) ``` Fixes: #25382 Fixes: #14917 Refs: nodejs/performance#93 Refs: nodejs/performance#89 PR-URL: #48523 Backport-PR-URL: #50098 Refs: v8/v8@1a782f6 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
1 parent 747fbb4 commit 7f68e14

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

tools/v8_gypfiles/features.gypi

+17
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,20 @@
6868
}, {
6969
'v8_enable_system_instrumentation': 0,
7070
}],
71+
['OS=="linux"', {
72+
# Sets -dV8_ENABLE_PRIVATE_MAPPING_FORK_OPTIMIZATION.
73+
#
74+
# This flag speeds up the performance of fork/execve on Linux systems for
75+
# embedders which use it (like Node.js). It works by marking the pages that
76+
# V8 allocates as MADV_DONTFORK. Without MADV_DONTFORK, the Linux kernel
77+
# spends a long time manipulating page mappings on fork and exec which the
78+
# child process doesn't generally need to access.
79+
#
80+
# See v8:7381 for more details.
81+
'v8_enable_private_mapping_fork_optimization': 1,
82+
}, {
83+
'v8_enable_private_mapping_fork_optimization': 0,
84+
}],
7185
],
7286
'is_debug%': 0,
7387

@@ -310,6 +324,9 @@
310324
['v8_enable_hugepage==1', {
311325
'defines': ['ENABLE_HUGEPAGE',],
312326
}],
327+
['v8_enable_private_mapping_fork_optimization==1', {
328+
'defines': ['V8_ENABLE_PRIVATE_MAPPING_FORK_OPTIMIZATION'],
329+
}],
313330
['v8_enable_vtunejit==1', {
314331
'defines': ['ENABLE_VTUNE_JIT_INTERFACE',],
315332
}],

0 commit comments

Comments
 (0)