Skip to content

Commit 7ac760b

Browse files
bnoordhuisMylesBorins
authored andcommitted
src: fix SetClientCertEngine() nullptr dereference
Introduced in commit 6ee985f ("tls: implement clientCertEngine option") which was merged November 11. PR-URL: #16965 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f6ec5fa commit 7ac760b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/node_crypto.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,8 @@ void SecureContext::SetClientCertEngine(
13481348
CHECK_EQ(args.Length(), 1);
13491349
CHECK(args[0]->IsString());
13501350

1351-
SecureContext* sc = Unwrap<SecureContext>(args.This());
1351+
SecureContext* sc;
1352+
ASSIGN_OR_RETURN_UNWRAP(&sc, args.Holder());
13521353

13531354
MarkPopErrorOnReturn mark_pop_error_on_return;
13541355

0 commit comments

Comments
 (0)