tools: prefer filter to remove empty strings

Ref: #23585 (comment)

Python's `list.remove` will throw if the element is not found and also
it removes only the first occurrence.

This patch replaces the use of `list.remove` with a `filter` which
solves both of the above mentioned problems.

PR-URL: #23727
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: thefourtheye

tools/test.py

@@ -1381,8 +1381,8 @@ def ProcessOptions(options):
   options.arch = options.arch.split(',')
   options.mode = options.mode.split(',')
   options.run = options.run.split(',')
-  options.skip_tests = options.skip_tests.split(',')
-  options.skip_tests.remove("")
+  # Split at commas and filter out all the empty strings.
+  options.skip_tests = filter(bool, options.skip_tests.split(','))
   if options.run == [""]:
     options.run = None
   elif len(options.run) != 2: