Skip to content

Commit 6cb4cc2

Browse files
TrottMylesBorins
authored andcommitted
test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes simultaneously. On Fedora 24, this can result in EAGAIN "Resource temporarily unavailable" errors. When this occurs, simply try to launch a worker again. PR-URL: #17598 Fixes: #17589 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent ed4d013 commit 6cb4cc2

File tree

1 file changed

+32
-16
lines changed

1 file changed

+32
-16
lines changed

test/sequential/test-child-process-pass-fd.js

+32-16
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,42 @@ const { fork } = require('child_process');
1818
const net = require('net');
1919

2020
const N = 80;
21+
let messageCallbackCount = 0;
2122

22-
if (process.argv[2] !== 'child') {
23-
for (let i = 0; i < N; ++i) {
24-
const worker = fork(__filename, ['child']);
25-
worker.once('message', common.mustCall((msg, handle) => {
26-
assert.strictEqual(msg, 'handle');
27-
assert.ok(handle);
28-
worker.send('got');
29-
30-
let recvData = '';
31-
handle.on('data', common.mustCall((data) => {
32-
recvData += data;
33-
}));
23+
function forkWorker() {
24+
const messageCallback = (msg, handle) => {
25+
messageCallbackCount++;
26+
assert.strictEqual(msg, 'handle');
27+
assert.ok(handle);
28+
worker.send('got');
3429

35-
handle.on('end', () => {
36-
assert.strictEqual(recvData, 'hello');
37-
worker.kill();
38-
});
30+
let recvData = '';
31+
handle.on('data', common.mustCall((data) => {
32+
recvData += data;
3933
}));
34+
35+
handle.on('end', () => {
36+
assert.strictEqual(recvData, 'hello');
37+
worker.kill();
38+
});
39+
};
40+
41+
const worker = fork(__filename, ['child']);
42+
worker.on('error', (err) => {
43+
if (/\bEAGAIN\b/.test(err.message)) {
44+
forkWorker();
45+
return;
46+
}
47+
throw err;
48+
});
49+
worker.once('message', messageCallback);
50+
}
51+
52+
if (process.argv[2] !== 'child') {
53+
for (let i = 0; i < N; ++i) {
54+
forkWorker();
4055
}
56+
process.on('exit', () => { assert.strictEqual(messageCallbackCount, N); });
4157
} else {
4258
let socket;
4359
let cbcalls = 0;

0 commit comments

Comments
 (0)