Skip to content

Commit 6c46681

Browse files
danbevtargos
danbev
authored and
targos
committed
src: name all builtin init functions Initialize
This commit renames a few of the builtin modules init functions to Initialize for consistency. PR-URL: #19550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 1a38b9b commit 6c46681

14 files changed

+54
-54
lines changed

‎src/inspector_js_api.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,8 @@ void Url(const FunctionCallbackInfo<Value>& args) {
298298
args.GetReturnValue().Set(OneByteString(env->isolate(), url.c_str()));
299299
}
300300

301-
void InitInspectorBindings(Local<Object> target, Local<Value> unused,
302-
Local<Context> context, void* priv) {
301+
void Initialize(Local<Object> target, Local<Value> unused,
302+
Local<Context> context, void* priv) {
303303
Environment* env = Environment::GetCurrent(context);
304304
{
305305
auto obj = Object::New(env->isolate());
@@ -343,4 +343,4 @@ void InitInspectorBindings(Local<Object> target, Local<Value> unused,
343343
} // namespace node
344344

345345
NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector,
346-
node::inspector::InitInspectorBindings);
346+
node::inspector::Initialize);

‎src/node.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -4910,7 +4910,7 @@ void RegisterBuiltinModules() {
49104910
} // namespace node
49114911

49124912
#if !HAVE_INSPECTOR
4913-
void InitEmptyBindings() {}
4913+
void Initialize() {}
49144914

4915-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, InitEmptyBindings)
4915+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, Initialize)
49164916
#endif // !HAVE_INSPECTOR

‎src/node_config.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ using v8::Value;
3636
value, ReadOnly).FromJust(); \
3737
} while (0)
3838

39-
static void InitConfig(Local<Object> target,
39+
static void Initialize(Local<Object> target,
4040
Local<Value> unused,
4141
Local<Context> context) {
4242
Environment* env = Environment::GetCurrent(context);
@@ -138,4 +138,4 @@ static void InitConfig(Local<Object> target,
138138

139139
} // namespace node
140140

141-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(config, node::InitConfig)
141+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(config, node::Initialize)

‎src/node_contextify.cc

+4-4
Original file line numberDiff line numberDiff line change
@@ -1155,9 +1155,9 @@ class ContextifyScript : public BaseObject {
11551155
};
11561156

11571157

1158-
void InitContextify(Local<Object> target,
1159-
Local<Value> unused,
1160-
Local<Context> context) {
1158+
void Initialize(Local<Object> target,
1159+
Local<Value> unused,
1160+
Local<Context> context) {
11611161
Environment* env = Environment::GetCurrent(context);
11621162
ContextifyContext::Init(env, target);
11631163
ContextifyScript::Init(env, target);
@@ -1166,4 +1166,4 @@ void InitContextify(Local<Object> target,
11661166
} // namespace contextify
11671167
} // namespace node
11681168

1169-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(contextify, node::contextify::InitContextify)
1169+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(contextify, node::contextify::Initialize)

‎src/node_crypto.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -6268,7 +6268,7 @@ void SetFipsCrypto(const FunctionCallbackInfo<Value>& args) {
62686268
}
62696269
#endif /* NODE_FIPS_MODE */
62706270

6271-
void InitCrypto(Local<Object> target,
6271+
void Initialize(Local<Object> target,
62726272
Local<Value> unused,
62736273
Local<Context> context,
62746274
void* priv) {
@@ -6341,4 +6341,4 @@ void InitCrypto(Local<Object> target,
63416341
} // namespace crypto
63426342
} // namespace node
63436343

6344-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(crypto, node::crypto::InitCrypto)
6344+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(crypto, node::crypto::Initialize)

‎src/node_http_parser.cc

+5-5
Original file line numberDiff line numberDiff line change
@@ -711,10 +711,10 @@ const struct http_parser_settings Parser::settings = {
711711
};
712712

713713

714-
void InitHttpParser(Local<Object> target,
715-
Local<Value> unused,
716-
Local<Context> context,
717-
void* priv) {
714+
void Initialize(Local<Object> target,
715+
Local<Value> unused,
716+
Local<Context> context,
717+
void* priv) {
718718
Environment* env = Environment::GetCurrent(context);
719719
Local<FunctionTemplate> t = env->NewFunctionTemplate(Parser::New);
720720
t->InstanceTemplate()->SetInternalFieldCount(1);
@@ -761,4 +761,4 @@ void InitHttpParser(Local<Object> target,
761761
} // anonymous namespace
762762
} // namespace node
763763

764-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(http_parser, node::InitHttpParser)
764+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(http_parser, node::Initialize)

‎src/node_i18n.cc

+5-5
Original file line numberDiff line numberDiff line change
@@ -852,10 +852,10 @@ static void GetStringWidth(const FunctionCallbackInfo<Value>& args) {
852852
args.GetReturnValue().Set(width);
853853
}
854854

855-
void Init(Local<Object> target,
856-
Local<Value> unused,
857-
Local<Context> context,
858-
void* priv) {
855+
void Initialize(Local<Object> target,
856+
Local<Value> unused,
857+
Local<Context> context,
858+
void* priv) {
859859
Environment* env = Environment::GetCurrent(context);
860860
env->SetMethod(target, "toUnicode", ToUnicode);
861861
env->SetMethod(target, "toASCII", ToASCII);
@@ -875,6 +875,6 @@ void Init(Local<Object> target,
875875
} // namespace i18n
876876
} // namespace node
877877

878-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(icu, node::i18n::Init)
878+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(icu, node::i18n::Initialize)
879879

880880
#endif // NODE_HAVE_I18N_SUPPORT

‎src/node_perf.cc

+4-4
Original file line numberDiff line numberDiff line change
@@ -347,9 +347,9 @@ void Timerify(const FunctionCallbackInfo<Value>& args) {
347347
}
348348

349349

350-
void Init(Local<Object> target,
351-
Local<Value> unused,
352-
Local<Context> context) {
350+
void Initialize(Local<Object> target,
351+
Local<Value> unused,
352+
Local<Context> context) {
353353
Environment* env = Environment::GetCurrent(context);
354354
Isolate* isolate = env->isolate();
355355
performance_state* state = env->performance_state();
@@ -418,4 +418,4 @@ void Init(Local<Object> target,
418418
} // namespace performance
419419
} // namespace node
420420

421-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(performance, node::performance::Init)
421+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(performance, node::performance::Initialize)

‎src/node_serdes.cc

+4-4
Original file line numberDiff line numberDiff line change
@@ -424,9 +424,9 @@ void DeserializerContext::ReadRawBytes(
424424
args.GetReturnValue().Set(offset);
425425
}
426426

427-
void InitializeSerdesBindings(Local<Object> target,
428-
Local<Value> unused,
429-
Local<Context> context) {
427+
void Initialize(Local<Object> target,
428+
Local<Value> unused,
429+
Local<Context> context) {
430430
Environment* env = Environment::GetCurrent(context);
431431
Local<FunctionTemplate> ser =
432432
env->NewFunctionTemplate(SerializerContext::New);
@@ -483,4 +483,4 @@ void InitializeSerdesBindings(Local<Object> target,
483483
} // anonymous namespace
484484
} // namespace node
485485

486-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(serdes, node::InitializeSerdesBindings)
486+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(serdes, node::Initialize)

‎src/node_trace_events.cc

+5-5
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,10 @@ static void CategoryGroupEnabled(const FunctionCallbackInfo<Value>& args) {
132132
args.GetReturnValue().Set(*category_group_enabled > 0);
133133
}
134134

135-
void InitializeTraceEvents(Local<Object> target,
136-
Local<Value> unused,
137-
Local<Context> context,
138-
void* priv) {
135+
void Initialize(Local<Object> target,
136+
Local<Value> unused,
137+
Local<Context> context,
138+
void* priv) {
139139
Environment* env = Environment::GetCurrent(context);
140140

141141
env->SetMethod(target, "emit", Emit);
@@ -144,4 +144,4 @@ void InitializeTraceEvents(Local<Object> target,
144144

145145
} // namespace node
146146

147-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(trace_events, node::InitializeTraceEvents)
147+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(trace_events, node::Initialize)

‎src/node_url.cc

+5-5
Original file line numberDiff line numberDiff line change
@@ -2290,10 +2290,10 @@ static void SetURLConstructor(const FunctionCallbackInfo<Value>& args) {
22902290
env->set_url_constructor_function(args[0].As<Function>());
22912291
}
22922292

2293-
static void Init(Local<Object> target,
2294-
Local<Value> unused,
2295-
Local<Context> context,
2296-
void* priv) {
2293+
static void Initialize(Local<Object> target,
2294+
Local<Value> unused,
2295+
Local<Context> context,
2296+
void* priv) {
22972297
Environment* env = Environment::GetCurrent(context);
22982298
env->SetMethod(target, "parse", Parse);
22992299
env->SetMethod(target, "encodeAuth", EncodeAuthSet);
@@ -2313,4 +2313,4 @@ static void Init(Local<Object> target,
23132313
} // namespace url
23142314
} // namespace node
23152315

2316-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(url, node::url::Init)
2316+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(url, node::url::Initialize)

‎src/node_v8.cc

+4-4
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ void SetFlagsFromString(const FunctionCallbackInfo<Value>& args) {
119119
}
120120

121121

122-
void InitializeV8Bindings(Local<Object> target,
123-
Local<Value> unused,
124-
Local<Context> context) {
122+
void Initialize(Local<Object> target,
123+
Local<Value> unused,
124+
Local<Context> context) {
125125
Environment* env = Environment::GetCurrent(context);
126126

127127
env->SetMethod(target, "cachedDataVersionTag", CachedDataVersionTag);
@@ -201,4 +201,4 @@ void InitializeV8Bindings(Local<Object> target,
201201

202202
} // namespace node
203203

204-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(v8, node::InitializeV8Bindings)
204+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(v8, node::Initialize)

‎src/node_zlib.cc

+5-5
Original file line numberDiff line numberDiff line change
@@ -681,10 +681,10 @@ class ZCtx : public AsyncWrap {
681681
};
682682

683683

684-
void InitZlib(Local<Object> target,
685-
Local<Value> unused,
686-
Local<Context> context,
687-
void* priv) {
684+
void Initialize(Local<Object> target,
685+
Local<Value> unused,
686+
Local<Context> context,
687+
void* priv) {
688688
Environment* env = Environment::GetCurrent(context);
689689
Local<FunctionTemplate> z = env->NewFunctionTemplate(ZCtx::New);
690690

@@ -709,4 +709,4 @@ void InitZlib(Local<Object> target,
709709
} // anonymous namespace
710710
} // namespace node
711711

712-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(zlib, node::InitZlib)
712+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(zlib, node::Initialize)

‎src/uv.cc

+4-4
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ void ErrName(const FunctionCallbackInfo<Value>& args) {
5050
}
5151

5252

53-
void InitializeUV(Local<Object> target,
54-
Local<Value> unused,
55-
Local<Context> context) {
53+
void Initialize(Local<Object> target,
54+
Local<Value> unused,
55+
Local<Context> context) {
5656
Environment* env = Environment::GetCurrent(context);
5757
Isolate* isolate = env->isolate();
5858
target->Set(FIXED_ONE_BYTE_STRING(isolate, "errname"),
@@ -82,4 +82,4 @@ void InitializeUV(Local<Object> target,
8282
} // anonymous namespace
8383
} // namespace node
8484

85-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(uv, node::InitializeUV)
85+
NODE_BUILTIN_MODULE_CONTEXT_AWARE(uv, node::Initialize)

0 commit comments

Comments
 (0)