Skip to content

Commit 6bc49f0

Browse files
trivikrtargos
authored andcommitted
test: http2 errors on req.close()
Backport-PR-URL: #19579 PR-URL: #18854 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 9a146c6 commit 6bc49f0

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

test/parallel/test-http2-client-rststream-before-connect.js

+16-4
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,38 @@ server.on('stream', (stream) => {
1616
server.listen(0, common.mustCall(() => {
1717
const client = h2.connect(`http://localhost:${server.address().port}`);
1818
const req = client.request();
19-
req.close(1);
19+
const closeCode = 1;
20+
21+
common.expectsError(
22+
() => req.close(2 ** 32),
23+
{
24+
type: RangeError,
25+
code: 'ERR_OUT_OF_RANGE',
26+
message: 'The "code" argument is out of range'
27+
}
28+
);
29+
assert.strictEqual(req.closed, false);
30+
31+
req.close(closeCode, common.mustCall());
2032
assert.strictEqual(req.closed, true);
2133

2234
// Make sure that destroy is called.
2335
req._destroy = common.mustCall(req._destroy.bind(req));
2436

2537
// Second call doesn't do anything.
26-
req.close(8);
38+
req.close(closeCode + 1);
2739

2840
req.on('close', common.mustCall((code) => {
2941
assert.strictEqual(req.destroyed, true);
30-
assert.strictEqual(code, 1);
42+
assert.strictEqual(code, closeCode);
3143
server.close();
3244
client.close();
3345
}));
3446

3547
req.on('error', common.expectsError({
3648
code: 'ERR_HTTP2_STREAM_ERROR',
3749
type: Error,
38-
message: 'Stream closed with error code 1'
50+
message: `Stream closed with error code ${closeCode}`
3951
}));
4052

4153
req.on('response', common.mustCall());

0 commit comments

Comments
 (0)