cluster: fix fd leak

PR-URL: #43650
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

Author: theanarkh

lib/internal/cluster/child.js

@@ -210,6 +210,8 @@ function onconnection(message, handle) {
 
   if (accepted)
     server.onconnection(0, handle);
+  else
+    handle.close();
 }
 
 function send(message, cb) {

test/parallel/test-cluster-worker-handle-close.js

@@ -0,0 +1,27 @@
+'use strict';
+const common = require('../common');
+const cluster = require('cluster');
+const net = require('net');
+
+if (cluster.isPrimary) {
+  cluster.schedulingPolicy = cluster.SCHED_RR;
+  cluster.fork();
+} else {
+  const server = net.createServer(common.mustNotCall());
+  server.listen(0, common.mustCall(() => {
+    net.connect(server.address().port);
+  }));
+  process.prependListener('internalMessage', common.mustCallAtLeast((message, handle) => {
+    if (message.act !== 'newconn') {
+      return;
+    }
+    // Make the worker drops the connection, see `rr` and `onconnection` in child.js
+    server.close();
+    const close = handle.close;
+    handle.close = common.mustCall(() => {
+      close.call(handle, common.mustCall(() => {
+        process.exit();
+      }));
+    });
+  }));
+}