Skip to content

Commit 5cd1fd8

Browse files
Julien Gilliofrobots
Julien Gilli
authored andcommitted
deps: backport 56a0a79 from V8 upstream
Backport 56a0a797f210e04746f2888116365d29a4bb6afc from V8 upstream to include post-mortem metadata used by mdb_v8 to support V8 4.6. Original commit message: Update post-mortem metadata generation mdb_v8, a post-mortem debugger for Node.js, now uses JSArrayBuffer's backing_store property and JSArrayBufferView's byte_offset property to get access to the content of Buffer instances in node (which are Uint8Array instances). This change adds post-mortem metadata for these two properties. This change also fixes a typo in inobject_properties_of_constructor_function_index_offset that was added to gen-postmortem-metadata in a previous change. It should be named inobject_properties_or_constructor_function_index instead. [email protected] Review URL: https://codereview.chromium.org/1363403003 Cr-Commit-Position: refs/heads/master@{#30926} Ref: #3057 PR-URL: #3351 Reviewed-By: indutny - Fedor Indutny <[email protected]> Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
1 parent bbdbef9 commit 5cd1fd8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

deps/v8/tools/gen-postmortem-metadata.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,10 @@
151151
'JSObject, elements, Object, kElementsOffset',
152152
'FixedArray, data, uintptr_t, kHeaderSize',
153153
'JSTypedArray, length, Object, kLengthOffset',
154+
'JSArrayBuffer, backing_store, Object, kBackingStoreOffset',
155+
'JSArrayBufferView, byte_offset, Object, kByteOffsetOffset',
154156
'Map, instance_attributes, int, kInstanceAttributesOffset',
155-
'Map, inobject_properties_of_constructor_function_index_offset, int, kInObjectPropertiesOrConstructorFunctionIndexOffset',
157+
'Map, inobject_properties_or_constructor_function_index, int, kInObjectPropertiesOrConstructorFunctionIndexOffset',
156158
'Map, instance_size, int, kInstanceSizeOffset',
157159
'Map, bit_field, char, kBitFieldOffset',
158160
'Map, bit_field2, char, kBitField2Offset',

0 commit comments

Comments
 (0)