Skip to content

Commit 59fa7f1

Browse files
committedDec 27, 2018
deps: cherry-pick 26b145a from upstream V8
Original commit message: [api] Deprecate ExternalStringResourceBase::IsCompressible [email protected] Bug: v8:8238 Change-Id: Ia59aefc54c2e9f4fa3348c42fb45e7fadab8ee76 Reviewed-on: https://chromium-review.googlesource.com/c/1349231 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Andreas Haas <[email protected]> Cr-Commit-Position: refs/heads/master@{#57788} Refs: v8/v8@26b145a PR-URL: #25148 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent eaa1544 commit 59fa7f1

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed
 

‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.7',
41+
'v8_embedder_string': '-node.8',
4242

4343
##### V8 defaults for Node.js #####
4444

‎deps/v8/include/v8.h

+2-12
Original file line numberDiff line numberDiff line change
@@ -2631,8 +2631,7 @@ class V8_EXPORT String : public Name {
26312631
public:
26322632
virtual ~ExternalStringResourceBase() = default;
26332633

2634-
V8_DEPRECATE_SOON("Use IsCacheable().",
2635-
virtual bool IsCompressible() const) {
2634+
V8_DEPRECATED("Use IsCacheable().", virtual bool IsCompressible() const) {
26362635
return false;
26372636
}
26382637

@@ -2641,16 +2640,7 @@ class V8_EXPORT String : public Name {
26412640
* ExternalStringResource::data() may be cached, otherwise it is not
26422641
* expected to be stable beyond the current top-level task.
26432642
*/
2644-
virtual bool IsCacheable() const {
2645-
#if __clang__
2646-
#pragma clang diagnostic push
2647-
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
2648-
#endif
2649-
return !IsCompressible();
2650-
#if __clang__
2651-
#pragma clang diagnostic pop
2652-
#endif
2653-
}
2643+
virtual bool IsCacheable() const { return true; }
26542644

26552645
protected:
26562646
ExternalStringResourceBase() = default;

0 commit comments

Comments
 (0)