Skip to content

Commit 542f252

Browse files
authoredNov 26, 2024··
build: avoid compiling with VS v17.12
Refs: nodejs/build#3963 PR-URL: #55930 Refs: #53863 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 0ba264f commit 542f252

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed
 

‎vcbuild.bat

+10-1
Original file line numberDiff line numberDiff line change
@@ -292,10 +292,19 @@ goto exit
292292
@rem Visual Studio v17.10 has a bug that causes the build to fail.
293293
@rem Check if the version is v17.10 and exit if it is.
294294
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
295-
if %errorlevel% neq 1 (
295+
if %errorlevel% neq 1 (
296296
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
297297
goto exit
298298
)
299+
@rem Same applies to v17.12 for MSVC.
300+
echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
301+
if %errorlevel% neq 1 (
302+
@rem Clang 18.1.8 Provided with VS 17.12 works fine.
303+
if not defined clang_cl (
304+
echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
305+
goto exit
306+
)
307+
)
299308

300309
@rem check if the clang-cl build is requested
301310
if not defined clang_cl goto clang-skip

0 commit comments

Comments
 (0)
Please sign in to comment.