Skip to content

Commit 53f73d1

Browse files
committed
build: enable V8's trap handler on Windows
It can now be compiled with MSVC. PR-URL: #44741 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 4860ad9 commit 53f73d1

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

tools/v8_gypfiles/v8.gyp

+3-6
Original file line numberDiff line numberDiff line change
@@ -621,8 +621,7 @@
621621
'<(V8_ROOT)/src/trap-handler/handler-inside-posix.h',
622622
],
623623
}],
624-
# TODO(targos): Replace False with OS=="win" if handler-outside-simulator.cc becomes compatible with MSVC.
625-
['_toolset=="host" and host_arch=="x64" and (OS=="linux" or OS=="mac" or False)', {
624+
['_toolset=="host" and host_arch=="x64" and (OS=="linux" or OS=="mac" or OS=="win")', {
626625
'sources': [
627626
'<(V8_ROOT)/src/trap-handler/trap-handler-simulator.h',
628627
],
@@ -858,16 +857,14 @@
858857
'<(V8_ROOT)/src/trap-handler/handler-outside-posix.cc',
859858
],
860859
}],
861-
# TODO(targos): Replace False with OS=="win" if handler-outside-simulator.cc becomes compatible with MSVC.
862-
['_toolset=="host" and host_arch=="x64" and False', {
860+
['_toolset=="host" and host_arch=="x64" and OS=="win"', {
863861
'sources': [
864862
'<(V8_ROOT)/src/trap-handler/handler-inside-win.cc',
865863
'<(V8_ROOT)/src/trap-handler/handler-outside-win.cc',
866864
],
867865
}],
868-
# TODO(targos): Replace False with OS=="win" if handler-outside-simulator.cc becomes compatible with MSVC.
869866
['_toolset=="host" and host_arch=="x64" and '
870-
'(host_os=="linux" or host_os=="mac" or False)', {
867+
'(host_os=="linux" or host_os=="mac" or OS=="win")', {
871868
'sources': [
872869
'<(V8_ROOT)/src/trap-handler/handler-outside-simulator.cc',
873870
],

0 commit comments

Comments
 (0)