Skip to content

Commit 43e4c90

Browse files
committed
src: rename node to io.js for Windows installer
* quote "NODE_VERSION_STRING" in node.rc to allow for complex version strings * change user-facing strings * make sure .bat files are crlf PR-URL: #291 Reviewed-By: Bert Belder <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
1 parent dd260d2 commit 43e4c90

File tree

6 files changed

+43
-42
lines changed

6 files changed

+43
-42
lines changed

.gitattributes

+1
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
test/fixtures/* -text
2+
*.bat text eol=crlf

src/res/node.rc

+7-7
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,14 @@ BEGIN
5050
BEGIN
5151
BLOCK "040904b0"
5252
BEGIN
53-
VALUE "CompanyName", "Joyent, Inc"
54-
VALUE "ProductName", "Node.js"
55-
VALUE "FileDescription", "Node.js: Evented I/O for V8 JavaScript"
56-
VALUE "FileVersion", NODE_VERSION_STRING
57-
VALUE "ProductVersion", NODE_VERSION_STRING
53+
VALUE "CompanyName", "io.js"
54+
VALUE "ProductName", "io.js"
55+
VALUE "FileDescription", "io.js: Server-side JavaScript"
56+
VALUE "FileVersion", "NODE_VERSION_STRING"
57+
VALUE "ProductVersion", "NODE_VERSION_STRING"
5858
VALUE "OriginalFilename", "iojs.exe"
59-
VALUE "InternalName", "node"
60-
VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license."
59+
VALUE "InternalName", "iojs"
60+
VALUE "LegalCopyright", "Copyright io.js contributors. MIT license."
6161
END
6262
END
6363
BLOCK "VarFileInfo"

tools/msvs/msi/nodemsi.wixproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<ProductVersion>3.5</ProductVersion>
77
<ProjectGuid>{1d808ff0-b5a9-4be9-859d-b334b6f48be2}</ProjectGuid>
88
<SchemaVersion>2.0</SchemaVersion>
9-
<OutputName>node-v$(NodeVersion)-$(Platform)</OutputName>
9+
<OutputName>iojs-v$(NodeVersion)-$(Platform)</OutputName>
1010
<OutputType>Package</OutputType>
1111
<EnableProjectHarvesting>True</EnableProjectHarvesting>
1212
<WixTargetsPath Condition=" '$(WixTargetsPath)' == '' AND '$(MSBuildExtensionsPath32)' != '' ">$(MSBuildExtensionsPath32)\Microsoft\WiX\v3.x\Wix.targets</WixTargetsPath>

tools/msvs/msi/product.wxs

+25-25
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"
33
xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
44

5-
<?define ProductName = "Node.js" ?>
6-
<?define ProductDescription = "Node.js" ?>
7-
<?define ProductAuthor = "Joyent, Inc. and other Node contributors" ?>
5+
<?define ProductName = "io.js" ?>
6+
<?define ProductDescription = "io.js" ?>
7+
<?define ProductAuthor = "io.js contributors" ?>
88

9-
<?define RegistryKeyPath = "SOFTWARE\Node.js" ?>
9+
<?define RegistryKeyPath = "SOFTWARE\io.js" ?>
1010

1111
<?define RepoDir="$(var.ProjectDir)..\..\..\" ?>
1212
<?define SourceDir="$(var.RepoDir)\$(var.Configuration)\" ?>
@@ -23,11 +23,11 @@
2323
<Media Id="1" Cabinet="media1.cab" EmbedCab="yes"/>
2424

2525
<MajorUpgrade AllowSameVersionUpgrades="yes"
26-
DowngradeErrorMessage="A later version of node.js is already installed. Setup will now exit."/>
26+
DowngradeErrorMessage="A later version of io.js is already installed. Setup will now exit."/>
2727

2828
<Icon Id="NodeIcon" SourceFile="$(var.RepoDir)\src\res\node.ico"/>
2929
<Property Id="ARPPRODUCTICON" Value="NodeIcon"/>
30-
<Property Id="ApplicationFolderName" Value="nodejs"/>
30+
<Property Id="ApplicationFolderName" Value="iojs"/>
3131
<Property Id="WIXUI_INSTALLDIR" Value="INSTALLDIR"/>
3232

3333
<Property Id="INSTALLDIR">
@@ -40,8 +40,8 @@
4040

4141
<Feature Id="NodeRuntime"
4242
Level="1"
43-
Title="Node.js runtime"
44-
Description="Install the core Node.js runtime (node.exe)."
43+
Title="io.js runtime"
44+
Description="Install the core io.js runtime (iojs.exe)."
4545
Absent="disallow">
4646
<ComponentRef Id="NodeExecutable"/>
4747
<ComponentRef Id="NodeVarsScript"/>
@@ -52,22 +52,22 @@
5252
<Feature Id="NodePerfCtrSupport"
5353
Level="1"
5454
Title="Performance counters"
55-
Description="Installs support for Node.js-specific performance counters.">
55+
Description="Installs support for io.js-specific performance counters.">
5656
<ComponentRef Id="NodePerfCtrSupport"/>
5757
</Feature>
5858

5959
<Feature Id="NodeEtwSupport"
6060
Level="1"
6161
Title="Event tracing (ETW)"
62-
Description="Installs support for event tracing (ETW) events generated by Node.js.">
62+
Description="Installs support for event tracing (ETW) events generated by io.js.">
6363
<ComponentRef Id="NodeEtwSupport"/>
6464
</Feature>
6565
</Feature>
6666

6767
<Feature Id="npm"
6868
Level="1"
6969
Title="npm package manager"
70-
Description="Install npm, the recommended package manager for Node.js.">
70+
Description="Install npm, the recommended package manager for io.js.">
7171
<ComponentRef Id="NpmCmdScript"/>
7272
<ComponentRef Id="NpmBashScript"/>
7373
<ComponentRef Id="NpmConfigurationFile"/>
@@ -78,18 +78,18 @@
7878
<Feature Level="1"
7979
Id="DocumentationShortcuts"
8080
Title="Online documentation shortcuts"
81-
Description="Add start menu entries that link the the online documentation for Node.js $(var.ProductVersion) and the Node.js website.">
81+
Description="Add start menu entries that link the the online documentation for io.js $(var.ProductVersion) and the io.js website.">
8282
<ComponentRef Id="DocumentationShortcuts"/>
8383
</Feature>
8484

8585
<Feature Id="EnvironmentPath"
8686
Level="1"
8787
Title="Add to PATH"
88-
Description="Add Node, npm, and modules that were globally installed by npm to the PATH environment variable.">
88+
Description="Add io.js, npm, and modules that were globally installed by npm to the PATH environment variable.">
8989
<Feature Id="EnvironmentPathNode"
9090
Level="1"
91-
Title="Node and npm"
92-
Description="Add Node and npm (if installed) to the PATH environment variable.">
91+
Title="io.js and npm"
92+
Description="Add io.js and npm (if installed) to the PATH environment variable.">
9393
<ComponentRef Id="EnvironmentPathNode"/>
9494
</Feature>
9595

@@ -103,11 +103,11 @@
103103

104104
<Directory Id="TARGETDIR" Name="SourceDir">
105105
<Directory Id="ProgramMenuFolder">
106-
<Directory Id="ApplicationProgramsFolder" Name="Node.js"/>
106+
<Directory Id="ApplicationProgramsFolder" Name="io.js"/>
107107
</Directory>
108108

109109
<Directory Id="$(var.ProgramFilesFolderId)">
110-
<Directory Id="INSTALLDIR" Name="nodejs">
110+
<Directory Id="INSTALLDIR" Name="iojs">
111111
</Directory>
112112
</Directory>
113113
</Directory>
@@ -152,17 +152,17 @@
152152
Type="string"
153153
Value="$(var.ProductVersion)"/>
154154
<Shortcut Id="NodeVarsScriptShortcut"
155-
Name="Node.js command prompt"
155+
Name="io.js command prompt"
156156
Target="[%ComSpec]"
157157
Arguments='/k "[INSTALLDIR]nodevars.bat"'
158158
Show="normal"
159159
WorkingDirectory="INSTALLDIR"/>
160160
<Shortcut Id="NodeExecutableShortcut"
161-
Name="Node.js"
161+
Name="io.js"
162162
Target="[INSTALLDIR]iojs.exe"
163163
WorkingDirectory="INSTALLDIR"/>
164164
<Shortcut Id="UninstallProduct"
165-
Name="Uninstall Node.js"
165+
Name="Uninstall io.js"
166166
Target="[SystemFolder]msiexec.exe"
167167
Arguments="/x [ProductCode]"/>
168168
<RemoveFolder Id="RemoveApplicationProgramsFolder"
@@ -207,12 +207,12 @@
207207
Value="1"
208208
KeyPath="yes"/>
209209
<util:InternetShortcut Id="WebsiteShortcut"
210-
Name="Node.js website"
211-
Target="http://nodejs.org"
210+
Name="io.js website"
211+
Target="http://iojs.org"
212212
Type="url"/>
213213
<util:InternetShortcut Id="DocsShortcut"
214-
Name="Node.js documentation"
215-
Target="http://nodejs.org/dist/v$(var.ProductVersion)/docs/api/"
214+
Name="io.js documentation"
215+
Target="https://iojs.org/dist/v$(var.ProductVersion)/docs/api/"
216216
Type="url"/>
217217
</Component>
218218
</DirectoryRef>
@@ -293,7 +293,7 @@
293293
<Publish Dialog="CustomizeDlg" Control="Back" Event="NewDialog" Value="InstallDirDlg" Order="2">NOT Installed</Publish>
294294
<Publish Dialog="CustomizeDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg">1</Publish>
295295

296-
<Property Id="WIXUI_EXITDIALOGOPTIONALTEXT" Value="Node.js has been successfully installed."/>
296+
<Property Id="WIXUI_EXITDIALOGOPTIONALTEXT" Value="io.js has been successfully installed."/>
297297
</UI>
298298

299299
<UIRef Id="WixUI_Common"/>

tools/msvs/nodevars.bat

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
@echo off
22

3-
rem Ensure this Node.js and npm are first in the PATH
3+
rem Ensure this io.js and npm are first in the PATH
44
set PATH=%APPDATA%\npm;%~dp0;%PATH%
55

66
setlocal enabledelayedexpansion
77
pushd "%~dp0"
88

9-
rem Figure out the node version.
9+
rem Figure out the io.js version.
1010
set print_version=.\iojs.exe -p -e "process.versions.node + ' (' + process.arch + ')'"
1111
for /F "usebackq delims=" %%v in (`%print_version%`) do set version=%%v
1212

1313
rem Print message.
1414
if exist npm.cmd (
15-
echo Your environment has been set up for using Node.js !version! and npm.
15+
echo Your environment has been set up for using io.js !version! and npm.
1616
) else (
17-
echo Your environment has been set up for using Node.js !version!.
17+
echo Your environment has been set up for using io.js !version!.
1818
)
1919

2020
popd
2121
endlocal
2222

23-
rem If we're in the node.js directory, change to the user's home dir.
23+
rem If we're in the io.js directory, change to the user's home dir.
2424
if "%CD%\"=="%~dp0" cd /d "%HOMEDRIVE%%HOMEPATH%"

vcbuild.bat

+4-4
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ if errorlevel 1 goto exit
130130
@rem Skip signing if the `nosign` option was specified.
131131
if defined nosign goto licensertf
132132

133-
signtool sign /a /d "Node.js" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\iojs.exe
133+
signtool sign /a /d "io.js" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\iojs.exe
134134
if errorlevel 1 echo Failed to sign exe&goto exit
135135

136136
:licensertf
@@ -149,12 +149,12 @@ if not defined NIGHTLY goto msibuild
149149
set NODE_VERSION=%NODE_VERSION%.%NIGHTLY%
150150

151151
:msibuild
152-
echo Building node-%NODE_VERSION%
152+
echo Building iojs-%NODE_VERSION%
153153
msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /m /t:Clean,Build /p:Configuration=%config% /p:Platform=%msiplatform% /p:NodeVersion=%NODE_VERSION% %noetw_msi_arg% %noperfctr_msi_arg% /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo
154154
if errorlevel 1 goto exit
155155

156156
if defined nosign goto run
157-
signtool sign /a /d "Node.js" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\node-v%NODE_VERSION%-%msiplatform%.msi
157+
signtool sign /a /d "io.js" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\iojs-v%NODE_VERSION%-%msiplatform%.msi
158158
if errorlevel 1 echo Failed to sign msi&goto exit
159159

160160
:run
@@ -218,5 +218,5 @@ rem ***************
218218
:getnodeversion
219219
set NODE_VERSION=
220220
for /F "usebackq tokens=*" %%i in (`python "%~dp0tools\getnodeversion.py"`) do set NODE_VERSION=%%i
221-
if not defined NODE_VERSION echo Cannot determine current version of node.js & exit /b 1
221+
if not defined NODE_VERSION echo Cannot determine current version of io.js & exit /b 1
222222
goto :EOF

0 commit comments

Comments
 (0)