Skip to content

Commit 3ac05b7

Browse files
richard-townsend-armcodebytere
authored andcommittedJun 18, 2020
build: zlib build error on Windows on Arm
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: #33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent fc03224 commit 3ac05b7

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed
 

‎tools/v8_gypfiles/v8.gyp

+7-1
Original file line numberDiff line numberDiff line change
@@ -1650,7 +1650,13 @@
16501650
'toolsets': ['host', 'target'],
16511651
}],
16521652
['OS=="win"', {
1653-
'defines': ['X86_WINDOWS'],
1653+
'conditions': [
1654+
['"<(target_arch)"=="arm64" and _toolset=="target"', {
1655+
'defines': ['CPU_NO_SIMD']
1656+
}, {
1657+
'defines': ['X86_WINDOWS']
1658+
}]
1659+
]
16541660
}],
16551661
],
16561662
'direct_dependent_settings': {

0 commit comments

Comments
 (0)
Please sign in to comment.