Skip to content

Commit 3136578

Browse files
Trottevanlucas
authored andcommitted
test: make test-tls-external-accessor agnostic
Remove reliance on V8-specific error messages in test/parallel/test-tls-external-accessor.js. Check that the error is a `TypeError`. The test should now be successful without modification using ChakraCore. PR-URL: #16272 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
1 parent 0be7f8c commit 3136578

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-tls-external-accessor.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ const tls = require('tls');
1111
{
1212
const pctx = tls.createSecureContext().context;
1313
const cctx = Object.create(pctx);
14-
assert.throws(() => cctx._external, /incompatible receiver/);
14+
assert.throws(() => cctx._external, TypeError);
1515
pctx._external;
1616
}
1717
{
1818
const pctx = tls.createSecurePair().credentials.context;
1919
const cctx = Object.create(pctx);
20-
assert.throws(() => cctx._external, /incompatible receiver/);
20+
assert.throws(() => cctx._external, TypeError);
2121
pctx._external;
2222
}

0 commit comments

Comments
 (0)