Skip to content

Commit 2815bd3

Browse files
RafaelGSSdanielleadams
authored andcommitted
doc: clarify release process for new releasers
PR-URL: #43739 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
1 parent 6f1d2df commit 2815bd3

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

doc/contributing/releases.md

+16-1
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,20 @@ failed build if you start again!
468468
Jenkins collects the artifacts from the builds, allowing you to download and
469469
install the new build. Make sure that the build appears correct. Check the
470470
version numbers, and perform some basic checks to confirm that all is well with
471-
the build before moving forward.
471+
the build before moving forward. Use the following list as a baseline:
472+
473+
* `process.version` is as expected
474+
* `process.release` is as expected
475+
* `process.versions` is as expected (for example, `openssl` or `llhttp` version
476+
must be in the expected updated version)
477+
* npm version (check it matches what we expect)
478+
* Run the test suite against the built binaries (optional)
479+
480+
```console
481+
./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
482+
```
483+
484+
<sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup>
472485

473486
### 11. Tag and sign the release commit
474487

@@ -510,6 +523,8 @@ include the release code name.
510523
The tag **must** be signed using the GPG key that's listed for you on the
511524
project README.
512525

526+
**Note**: Don't push the tag to remote at this point.
527+
513528
### 12. Set up for the next release
514529

515530
On release proposal branch, edit `src/node_version.h` again and:

0 commit comments

Comments
 (0)